From: Maximilian Luz <luzmaximilian@gmail.com>
To: Tian Tao <tiantao6@hisilicon.com>,
hdegoede@redhat.com, mgross@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/surface: aggregator: move to use request_irq by IRQF_NO_AUTOEN flag
Date: Wed, 7 Apr 2021 10:39:29 +0200 [thread overview]
Message-ID: <8734116a-2da6-60fe-e8bf-e273a27205ac@gmail.com> (raw)
In-Reply-To: <1617778852-26492-1-git-send-email-tiantao6@hisilicon.com>
On 4/7/21 9:00 AM, Tian Tao wrote:
> disable_irq() after request_irq() still has a time gap in which
> interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
> disable IRQ auto-enable because of requesting.
>
> this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
> is being merged: https://lore.kernel.org/patchwork/patch/1388765/
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Looks good to me.
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
Thanks,
Max
> ---
> drivers/platform/surface/aggregator/controller.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/surface/aggregator/controller.c b/drivers/platform/surface/aggregator/controller.c
> index aa6f37b..00e3828 100644
> --- a/drivers/platform/surface/aggregator/controller.c
> +++ b/drivers/platform/surface/aggregator/controller.c
> @@ -2483,7 +2483,8 @@ int ssam_irq_setup(struct ssam_controller *ctrl)
> * interrupt, and let the SAM resume callback during the controller
> * resume process clear it.
> */
> - const int irqf = IRQF_SHARED | IRQF_ONESHOT | IRQF_TRIGGER_RISING;
> + const int irqf = IRQF_SHARED | IRQF_ONESHOT |
> + IRQF_TRIGGER_RISING | IRQF_NO_AUTOEN;
>
> gpiod = gpiod_get(dev, "ssam_wakeup-int", GPIOD_ASIS);
> if (IS_ERR(gpiod))
> @@ -2501,7 +2502,6 @@ int ssam_irq_setup(struct ssam_controller *ctrl)
> return status;
>
> ctrl->irq.num = irq;
> - disable_irq(ctrl->irq.num);
> return 0;
> }
>
>
next prev parent reply other threads:[~2021-04-07 8:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 7:00 [PATCH] platform/surface: aggregator: move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
2021-04-07 8:39 ` Maximilian Luz [this message]
2021-04-07 9:51 ` Hans de Goede
2021-04-07 12:30 ` tiantao (H)
2021-04-07 12:34 ` Hans de Goede
2021-04-07 18:05 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734116a-2da6-60fe-e8bf-e273a27205ac@gmail.com \
--to=luzmaximilian@gmail.com \
--cc=hdegoede@redhat.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tiantao6@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.