From: Florian Boor <florian.boor@kernelconcepts.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, Jonathan.Cameron@huawei.com,
Michael.Hennerich@analog.com
Subject: Re: [PATCH] iio: adc: ad799x: Implement selecting external reference voltage input on AD7991, AD7995 and AD7999.
Date: Wed, 8 Sep 2021 17:03:52 +0200 [thread overview]
Message-ID: <8734fb80-011d-cb07-8cfb-6a1c06417034@kernelconcepts.de> (raw)
In-Reply-To: <20210905122653.0e081ab2@jic23-huawei>
Hi,
On 05.09.21 13:26, Jonathan Cameron wrote:
> On Mon, 30 Aug 2021 16:59:34 +0200
> Normal convention on this (not helped here by the complete lack of
> a binding document for this device) would be that the driver would
> use the external vref is vref-supply is present.
>
> Currently the driver uses devm_regulator_get(). In this case it
> should be using devm_regulator_get_optional() as that will avoid a
> 'fake' regulator being provided.
okay right - in this case we could get rid of the additional setting and only if
there is no vref-supply provided we need to get a dummy.
> The driver will need a few changes to handle the possible error return
> from that call, but it shouldn't be too complicated.
I'll send an updated patch...
> If you are willing it would be great to have a binding description for
> this driver. I'm no sure how it has slipped through the net for so long!
I'll add this as well.
Greetings
Florian
--
The dream of yesterday Florian Boor
is the hope of today Tel: +49(0) 271-338857-15
and the reality of tomorrow. Fax: +49(0) 271-338857-29
[Robert Hutchings Goddard, 1904] florian.boor@kernelconcepts.de
http://www.kernelconcepts.de/en
kernel concepts GmbH
Hauptstraße 16
57074 Siegen
Deutschland
Geschäftsführer: Ole Reinhardt
HR Siegen, HR B 9613
next prev parent reply other threads:[~2021-09-08 15:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 14:59 [PATCH] iio: adc: ad799x: Implement selecting external reference voltage input on AD7991, AD7995 and AD7999 Florian Boor
2021-09-05 11:26 ` Jonathan Cameron
2021-09-08 15:03 ` Florian Boor [this message]
2021-09-05 11:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734fb80-011d-cb07-8cfb-6a1c06417034@kernelconcepts.de \
--to=florian.boor@kernelconcepts.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.