From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EF3BC433EF for ; Fri, 29 Apr 2022 01:21:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CD60410F606; Fri, 29 Apr 2022 01:21:50 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 290D010F606 for ; Fri, 29 Apr 2022 01:21:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651195309; x=1682731309; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=TO/8QqG9DoLhf6M9FTDw0iEzyyQ1R676u+UMeGE0OnY=; b=fcyHRl61hu5JEr58M+CxMGKD1dYpnxiagmNqj5PYtxs7ip0QrRBtxvju 2PGxfAQDO9nRv08wDKUh5CkUk+9pK1pK8OgC2At+OLK83fPpjGC0lvwIL NuAvVjlJ+tMR9KXSaTR9r6UKjlUG7XrBbM+w0j9CFdAq7CZIRTm7AQpH4 hrUFIDMGc8V2NpR2Z72/q7bRx8stu/JQ3ciynX8ke1WfVVsYKpdYzExJI K4mhyMK3qBTZoGMbJUtgXkQo+CEPLyBMcw7g0J+b6ayZHFrGWP+yyNnrD q0xfwfaBW0kA4QF44Cyqc63J/+yFon0IfrSqzsIxgBk/BZgSkTifIScJC g==; X-IronPort-AV: E=McAfee;i="6400,9594,10331"; a="265335551" X-IronPort-AV: E=Sophos;i="5.91,296,1647327600"; d="scan'208";a="265335551" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2022 18:21:48 -0700 X-IronPort-AV: E=Sophos;i="5.91,296,1647327600"; d="scan'208";a="731800372" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.8.103]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2022 18:21:48 -0700 Date: Thu, 28 Apr 2022 18:21:48 -0700 Message-ID: <8735hw65w3.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Andi Shyti In-Reply-To: References: <85b4fcd249fb577b1d2acee2a6d39be7178540ff.1650435571.git.ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH 5/9] drm/i915/pcode: Add a couple of pcode helpers X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sun, 24 Apr 2022 15:00:24 -0700, Andi Shyti wrote: > > Hi Ashutosh, > > On Tue, Apr 19, 2022 at 11:25:05PM -0700, Ashutosh Dixit wrote: > > From: Dale B Stimson > > > > Add a couple of helpers to help formatting pcode commands and improve code > > readability. > > Can you please add some more details on the helpers? Done in v3, please take a look. > > +/* > > + * Helpers for dGfx PCODE mailbox command formatting > > + */ > > +int __intel_gt_pcode_read(struct intel_gt *gt, u32 mbcmd, u32 p1, u32 p2, u32 *val); > > +int __intel_gt_pcode_write(struct intel_gt *gt, u32 mbcmd, u32 p1, u32 p2, u32 val); > > + > > +#define __snb_pcode_read(i915, mbcmd, p1, p2, val) \ > > + __intel_gt_pcode_read(&(i915)->gt0, mbcmd, p1, p2, val) > > + > > +#define __snb_pcode_write(i915, mbcmd, p1, p2, val) \ > > + __intel_gt_pcode_write(&(i915)->gt0, mbcmd, p1, p2, val) > > to_gt(i915) > > Why do we need these defines? Looks hacky and lazy. Can't we just > replace all __snb_pcode_read/write()? You are right, I've removed the #define's in v3. Thanks. -- Ashutosh