All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Mastan Katragadda <mastanx.katragadda@intel.com>
Cc: igt-dev@lists.freedesktop.org,
	tejaskumarx.surendrakumar.upadhyay@intel.com
Subject: Re: [igt-dev] [i-g-t] tests/i915/exec_balancer: Added Skip invalid-bonds
Date: Fri, 20 Aug 2021 14:44:44 -0700	[thread overview]
Message-ID: <8735r3aj03.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20210820020327.612886-1-mastanx.katragadda@intel.com>

On Thu, 19 Aug 2021 19:03:27 -0700, Mastan Katragadda wrote:
>
> Added skip which ever gen12+ platforms not supporting bonding.
>
> Disable bonding on gen12+ platforms aside from ones already supported by
> the i915 - TGL, RKL, and ADL-S.
>
> Link: https://cgit.freedesktop.org/drm-tip/commit/?id=ce7e75c7ef1bf8ea3d947da8c674d2f40fd7d73
>
> Changes since V1:
>	- Updated skip assertion logic (Ashutosh)

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

> Signed-off-by: Mastan Katragadda <mastanx.katragadda@intel.com>
> ---
>  tests/i915/gem_exec_balancer.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_exec_balancer.c b/tests/i915/gem_exec_balancer.c
> index 2f98950b..419efda7 100644
> --- a/tests/i915/gem_exec_balancer.c
> +++ b/tests/i915/gem_exec_balancer.c
> @@ -337,6 +337,7 @@ static void invalid_bonds(int i915)
>	};
>	uint32_t handle;
>	void *ptr;
> +	int ret;
>
>	memset(&engines, 0, sizeof(engines));
>	igt_assert_eq(__set_param_fresh_context(i915, p), 0);
> @@ -349,7 +350,9 @@ static void invalid_bonds(int i915)
>		bonds[n].num_bonds = 1;
>	}
>	engines.extensions = to_user_pointer(&bonds);
> -	igt_assert_eq(__set_param_fresh_context(i915, p), 0);
> +	ret = __set_param_fresh_context(i915, p);
> +	igt_skip_on_f(ret  == -ENODEV, "Bonding not supported\n");
> +	igt_assert_eq(ret, 0);
>
>	bonds[0].base.next_extension = -1ull;
>	igt_assert_eq(__set_param_fresh_context(i915, p), -EFAULT);
> --
> 2.25.1
>

  parent reply	other threads:[~2021-08-20 21:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20  2:03 [igt-dev] [i-g-t] tests/i915/exec_balancer: Added Skip invalid-bonds Mastan Katragadda
2021-08-20 11:09 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915/exec_balancer: Added Skip invalid-bonds (rev2) Patchwork
2021-08-20 13:34 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-08-20 21:44 ` Dixit, Ashutosh [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-08-19  6:10 [igt-dev] [i-g-t] tests/i915/exec_balancer: Added Skip invalid-bonds Mastan Katragadda
2021-08-19 19:46 ` Dixit, Ashutosh
2021-08-19 20:00   ` Dixit, Ashutosh
2021-08-20  1:47     ` Katragadda, MastanX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735r3aj03.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=mastanx.katragadda@intel.com \
    --cc=tejaskumarx.surendrakumar.upadhyay@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.