All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: peter.maydell@linaro.org, "Thomas Huth" <thuth@redhat.com>,
	qemu-devel@nongnu.org,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Willian Rampazzo" <willianr@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PULL 5/8] gitlab: work harder to avoid false positives in checkpatch
Date: Mon, 07 Jun 2021 17:14:35 +0100	[thread overview]
Message-ID: <8735ttodkw.fsf@linaro.org> (raw)
In-Reply-To: <YL4yRyLgD1avZdRE@redhat.com>


Daniel P. Berrangé <berrange@redhat.com> writes:

> On Mon, Jun 07, 2021 at 03:33:00PM +0100, Alex Bennée wrote:
>> This copies the behaviour of patchew's configuration to make the diff
>> algorithm generate a minimal diff.
>> 
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
>> Message-Id: <20210602153247.27651-1-alex.bennee@linaro.org>
>> 
>> diff --git a/.gitlab-ci.d/static_checks.yml b/.gitlab-ci.d/static_checks.yml
>> index 8e30872164..7e685c6a65 100644
>> --- a/.gitlab-ci.d/static_checks.yml
>> +++ b/.gitlab-ci.d/static_checks.yml
>> @@ -3,7 +3,11 @@ check-patch:
>>    image: $CI_REGISTRY_IMAGE/qemu/centos8:latest
>>    needs:
>>      job: amd64-centos8-container
>> -  script: .gitlab-ci.d/check-patch.py
>> +  script:
>> +    - git config --local diff.renamelimit 0
>> +    - git config --local diff.renames True
>> +    - git config --local diff.algorithm histogram
>> +    - .gitlab-ci.d/check-patch.py
>
> No objection to merging this patch as is, but I wonder if we ought to
> make scripts/checkpatch.pl set these options explicitly when it runs
> git, eg
>
>    git -c diff.renamelimit=0 -c diff.renames=True ...etc show
>
> so that everyone who runs checkpatch.pl benefits from the improvement.

Sure - I've generally held off messing with checkpatch directly because
of the general desire to keep it in-sync with upstream. Maybe that's
becoming less of a concern as time goes on?

[AJB says that with a totally straight face despite another patch in
this PR doing exactly that...]

>
> Regards,
> Daniel


-- 
Alex Bennée


  reply	other threads:[~2021-06-07 16:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07 14:32 [PULL 0/8] testing and misc updates Alex Bennée
2021-06-07 14:32 ` [PULL 1/8] tests/tcg: add a multiarch signals test to stress test signal delivery Alex Bennée
2021-06-07 14:32 ` [PULL 2/8] meson.build: fix cosmetics of compiler display Alex Bennée
2021-06-07 14:32 ` [PULL 3/8] tests/tcg/configure.sh: tweak quoting of target_compiler Alex Bennée
2021-06-07 14:32 ` [PULL 4/8] tests/acceptance: tag various arm tests as TCG only Alex Bennée
2021-06-07 14:33 ` [PULL 5/8] gitlab: work harder to avoid false positives in checkpatch Alex Bennée
2021-06-07 14:50   ` Daniel P. Berrangé
2021-06-07 16:14     ` Alex Bennée [this message]
2021-06-07 16:19       ` Daniel P. Berrangé
2021-06-07 14:33 ` [PULL 6/8] gitlab-ci: Split gprof-gcov job Alex Bennée
2021-06-07 14:33 ` [PULL 7/8] tests/vm: expose --source-path to scripts to find extra files Alex Bennée
2021-06-07 14:33 ` [PULL 8/8] scripts/checkpatch.pl: process .c.inc and .h.inc files as C source Alex Bennée
2021-06-07 16:17 ` [PULL 0/8] testing and misc updates Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735ttodkw.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=willianr@redhat.com \
    --subject='Re: [PULL 5/8] gitlab: work harder to avoid false positives in checkpatch' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.