All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/optee-client: disable -Werror
Date: Wed, 17 Mar 2021 19:57:49 +0100	[thread overview]
Message-ID: <8735wty5ea.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20210306225353.GX2275@scaer> (Yann E. MORIN's message of "Sat, 6 Mar 2021 23:53:53 +0100")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Fabrice, All,
 > On 2020-11-01 21:43 +0100, Fabrice Fontaine spake thusly:
 >> Disable -Werror thanks to CFG_WERROR which is available since version
 >> 3.3.0 and
 >> https://github.com/OP-TEE/optee_client/commit/5355fdb841bce4f7cce3dd37fc31fa91bd625c98
 >> to fix the following build failure with optee-client 3.11.0:
 >> 
 >> /home/giuliobenetti/autobuild/run/instance-2/output-1/build/optee-client-3.11.0/libckteec/src/pkcs11_processing.c: In function 'ck_create_object':
 >> /home/giuliobenetti/autobuild/run/instance-2/output-1/build/optee-client-3.11.0/libckteec/src/pkcs11_processing.c:22:9: error: missing initializer for field 'buffer' of 'struct serializer' [-Werror=missing-field-initializers]
 >> struct serializer obj = { };
 >> ^
 >> 
 >> Fixes:
 >> - http://autobuild.buildroot.org/results/a3d663adb943aee814180f01d6e153b3309be962
 >> 
 >> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

 > After reading the thread, I decided to apply this (oldish) patch to
 > next.

 > Indeed, as you mentionned in the thread, we do try to remove -Werror
 > when we hit issues with it.

 > -Werror is very important for the developpers of a package, because they
 > indeed can find and fix their code as early as possible.

 > But for downstreams, that does not help at all, especially since there
 > are a myriad of possible combination of binutils versions, compiler
 > versins, C libraries flavours and versions, optimisations flags and
 > architectures, that it is virtually impossible to guarantee a no-warning
 > build on all those combinations, especially when a new version of any of
 > those gets out.

 > So, applied to next, thanks.

Committed to 2021.02.x and 2020.11.x, thanks.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2021-03-17 18:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-01 20:43 [Buildroot] [PATCH 1/1] package/optee-client: disable -Werror Fabrice Fontaine
2020-11-02  6:07 ` Etienne Carriere
2020-11-02  7:10   ` Fabrice Fontaine
2020-11-02  8:16     ` Etienne Carriere
2020-11-03  9:57       ` Etienne Carriere
2020-11-03 13:48         ` Etienne Carriere
2020-11-03 17:32           ` Fabrice Fontaine
2020-11-03 17:56             ` Etienne Carriere
2021-03-06 22:53 ` Yann E. MORIN
2021-03-06 23:11   ` Etienne Carriere
2021-03-17 18:57   ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735wty5ea.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.