From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: Lars Povlsen <lars.povlsen@microchip.com>,
Thomas Gleixner <tglx@linutronix.de>,
Steen.Hegelund@microchip.com,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Marc Zyngier <maz@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Jason Cooper <jason@lakedaemon.net>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2 1/5] dt-bindings: interrupt-controller: convert icpu intr bindings to json-schema
Date: Mon, 16 Nov 2020 17:14:34 +0100 [thread overview]
Message-ID: <8736196zyt.fsf@BL-laptop> (raw)
In-Reply-To: <20201116144631.GA1623670@bogus>
Hello Rob,
> On Thu, 12 Nov 2020 17:04:20 +0100, Gregory CLEMENT wrote:
>> Convert device tree bindings for Microsemi Ocelot SoC ICPU Interrupt
>> Controller to YAML format
>>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
>> ---
>> .../mscc,ocelot-icpu-intr.txt | 21 -------
>> .../mscc,ocelot-icpu-intr.yaml | 59 +++++++++++++++++++
>> 2 files changed, 59 insertions(+), 21 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/mscc,ocelot-icpu-intr.txt
>> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/mscc,ocelot-icpu-intr.yaml
>>
>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/interrupt-controller/mscc,ocelot-icpu-intr.yaml:59:4: [error] no new line character at the end of file (new-line-at-end-of-file)
>
> dtschema/dtc warnings/errors:
> make[1]: *** [Documentation/devicetree/bindings/Makefile:59: Documentation/devicetree/bindings/processed-schema-examples.json] Error 123
> make: *** [Makefile:1364: dt_binding_check] Error 2
>
>
> See https://patchwork.ozlabs.org/patch/1399077
>
> The base for the patch is generally the last rc1. Any dependencies
> should be noted.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
I actually ran 'make dt_binding_check' and in the documentation there
was no reference of Documentation/devicetree/writing-schema.rst the need
of 'yamllint' while in the dependencies section of it was mentioned the
need of 'libyaml-dev'.
What do you think about updating the documentation ?
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
Sure I am doing it right now.
Gregory
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2020-11-16 16:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 16:04 [PATCH v2 0/5] Extend irqchip ocelot driver to support other SoCs Gregory CLEMENT
2020-11-12 16:04 ` [PATCH v2 1/5] dt-bindings: interrupt-controller: convert icpu intr bindings to json-schema Gregory CLEMENT
2020-11-16 14:46 ` Rob Herring
2020-11-16 16:14 ` Gregory CLEMENT [this message]
2020-11-12 16:04 ` [PATCH v2 2/5] dt-bindings: interrupt-controller: Add binding for few Microsemi interrupt controllers Gregory CLEMENT
2020-11-12 16:04 ` [PATCH v2 3/5] irqchip: ocelot: Add support for Luton platforms Gregory CLEMENT
2020-11-12 16:04 ` [PATCH v2 4/5] irqchip: ocelot: Add support for Serval platforms Gregory CLEMENT
2020-11-12 16:04 ` [PATCH v2 5/5] irqchip: ocelot: Add support for Jaguar2 platforms Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736196zyt.fsf@BL-laptop \
--to=gregory.clement@bootlin.com \
--cc=Steen.Hegelund@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=lars.povlsen@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.