From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D1EFC5517A for ; Sun, 25 Oct 2020 09:41:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBEA0222EC for ; Sun, 25 Oct 2020 09:41:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603618876; bh=kp4tBzl/d322MshJi6IkrrrXZvkCUwynlItkWMiT3Rw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=ytgu/uYZ4lL8F/5s5FqYTHWa3iINFoc63nqph6/B0mKLOjOfXrc+1/dkod9qjxvmq 7JJlcTqGEbDsQJ8QQEiH4lw2bAhXiKHWg3+88Ute1smATEAGBZERSTYspXPT+Nmq46 VfO7TMTnqkezIhNztyOEep1pCRNj0W+8qBqT/jP8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1414922AbgJYJlP (ORCPT ); Sun, 25 Oct 2020 05:41:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:46204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1414910AbgJYJlO (ORCPT ); Sun, 25 Oct 2020 05:41:14 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2871D22284; Sun, 25 Oct 2020 09:41:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603618874; bh=kp4tBzl/d322MshJi6IkrrrXZvkCUwynlItkWMiT3Rw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oCaPHBEX3SsSOsHUpk8UYzj5Q8oNDyjyYS1LhIINzZxiO2tYBGUlz3E3QZ+tAxc0T xgcCbqnJjLmZl3Q5N9rNRqZkjymnMrXPhsshz71ridpu6/XVl8lp0wsOmv5k+WBHCC KwRznIn9UWwOLolXoF/D+YwDRH0Ty/rxjfBPdh7Y= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kWcWW-0041qC-4M; Sun, 25 Oct 2020 09:41:12 +0000 Date: Sun, 25 Oct 2020 09:41:11 +0000 Message-ID: <873622prrc.wl-maz@kernel.org> From: Marc Zyngier To: David Woodhouse Cc: x86@kernel.org, kvm , iommu@lists.linux-foundation.org, joro@8bytes.org, Thomas Gleixner , Paolo Bonzini , linux-kernel , linux-hyperv@vger.kernel.org, Dexuan Cui Subject: Re: [PATCH v3 22/35] genirq/irqdomain: Implement get_name() method on irqchip fwnodes In-Reply-To: <20201024213535.443185-23-dwmw2@infradead.org> References: <20201024213535.443185-1-dwmw2@infradead.org> <20201024213535.443185-23-dwmw2@infradead.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: dwmw2@infradead.org, x86@kernel.org, kvm@vger.kernel.org, iommu@lists.linux-foundation.org, joro@8bytes.org, tglx@linutronix.de, pbonzini@redhat.com, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, decui@microsoft.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, nit: please use my kernel.org address for kernel related stuff. On Sat, 24 Oct 2020 22:35:22 +0100, David Woodhouse wrote: > > From: David Woodhouse > > Prerequesite to make x86 more irqdomain compliant. Prerequisite? > > Signed-off-by: David Woodhouse > Signed-off-by: Thomas Gleixner > --- > kernel/irq/irqdomain.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c > index cf8b374b892d..673fa64c1c44 100644 > --- a/kernel/irq/irqdomain.c > +++ b/kernel/irq/irqdomain.c > @@ -42,7 +42,16 @@ static inline void debugfs_add_domain_dir(struct irq_domain *d) { } > static inline void debugfs_remove_domain_dir(struct irq_domain *d) { } > #endif > > -const struct fwnode_operations irqchip_fwnode_ops; > +static const char *irqchip_fwnode_get_name(const struct fwnode_handle *fwnode) > +{ > + struct irqchip_fwid *fwid = container_of(fwnode, struct irqchip_fwid, fwnode); > + > + return fwid->name; > +} > + > +const struct fwnode_operations irqchip_fwnode_ops = { > + .get_name = irqchip_fwnode_get_name, > +}; > EXPORT_SYMBOL_GPL(irqchip_fwnode_ops); > > /** Acked-by: Marc Zyngier -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB039C56201 for ; Sun, 25 Oct 2020 09:41:17 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6DFDD22314 for ; Sun, 25 Oct 2020 09:41:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="oCaPHBEX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DFDD22314 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 1A07F87182; Sun, 25 Oct 2020 09:41:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NZy9W-77Ak3e; Sun, 25 Oct 2020 09:41:16 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 7BAE881E55; Sun, 25 Oct 2020 09:41:16 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5FF65C0893; Sun, 25 Oct 2020 09:41:16 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0F7FEC0859 for ; Sun, 25 Oct 2020 09:41:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 0B71D86B18 for ; Sun, 25 Oct 2020 09:41:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RA6vieaWb-bY for ; Sun, 25 Oct 2020 09:41:14 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 92C8686B11 for ; Sun, 25 Oct 2020 09:41:14 +0000 (UTC) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2871D22284; Sun, 25 Oct 2020 09:41:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603618874; bh=kp4tBzl/d322MshJi6IkrrrXZvkCUwynlItkWMiT3Rw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oCaPHBEX3SsSOsHUpk8UYzj5Q8oNDyjyYS1LhIINzZxiO2tYBGUlz3E3QZ+tAxc0T xgcCbqnJjLmZl3Q5N9rNRqZkjymnMrXPhsshz71ridpu6/XVl8lp0wsOmv5k+WBHCC KwRznIn9UWwOLolXoF/D+YwDRH0Ty/rxjfBPdh7Y= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kWcWW-0041qC-4M; Sun, 25 Oct 2020 09:41:12 +0000 Date: Sun, 25 Oct 2020 09:41:11 +0000 Message-ID: <873622prrc.wl-maz@kernel.org> From: Marc Zyngier To: David Woodhouse Subject: Re: [PATCH v3 22/35] genirq/irqdomain: Implement get_name() method on irqchip fwnodes In-Reply-To: <20201024213535.443185-23-dwmw2@infradead.org> References: <20201024213535.443185-1-dwmw2@infradead.org> <20201024213535.443185-23-dwmw2@infradead.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: dwmw2@infradead.org, x86@kernel.org, kvm@vger.kernel.org, iommu@lists.linux-foundation.org, joro@8bytes.org, tglx@linutronix.de, pbonzini@redhat.com, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, decui@microsoft.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: linux-hyperv@vger.kernel.org, kvm , x86@kernel.org, Dexuan Cui , linux-kernel , iommu@lists.linux-foundation.org, Paolo Bonzini , Thomas Gleixner X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi David, nit: please use my kernel.org address for kernel related stuff. On Sat, 24 Oct 2020 22:35:22 +0100, David Woodhouse wrote: > > From: David Woodhouse > > Prerequesite to make x86 more irqdomain compliant. Prerequisite? > > Signed-off-by: David Woodhouse > Signed-off-by: Thomas Gleixner > --- > kernel/irq/irqdomain.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c > index cf8b374b892d..673fa64c1c44 100644 > --- a/kernel/irq/irqdomain.c > +++ b/kernel/irq/irqdomain.c > @@ -42,7 +42,16 @@ static inline void debugfs_add_domain_dir(struct irq_domain *d) { } > static inline void debugfs_remove_domain_dir(struct irq_domain *d) { } > #endif > > -const struct fwnode_operations irqchip_fwnode_ops; > +static const char *irqchip_fwnode_get_name(const struct fwnode_handle *fwnode) > +{ > + struct irqchip_fwid *fwid = container_of(fwnode, struct irqchip_fwid, fwnode); > + > + return fwid->name; > +} > + > +const struct fwnode_operations irqchip_fwnode_ops = { > + .get_name = irqchip_fwnode_get_name, > +}; > EXPORT_SYMBOL_GPL(irqchip_fwnode_ops); > > /** Acked-by: Marc Zyngier -- Without deviation from the norm, progress is not possible. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu