From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Date: Thu, 10 Sep 2020 20:14:19 +0000 Subject: Re: [PATCH] drm/i915: Fix an error code i915_gem_object_copy_blt() Message-Id: <87363p4cf8.fsf@gaia.fi.intel.com> List-Id: References: <20200910100850.GD79916@mwanda> In-Reply-To: <20200910100850.GD79916@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Jani Nikula , Maarten Lankhorst Cc: David Airlie , kernel-janitors@vger.kernel.org, intel-gfx@lists.freedesktop.org, Chris Wilson , Matthew Auld Dan Carpenter writes: > This code should use "vma[1]" instead of "vma". The "vma" is a variable > is a valid pointer. Not quite getting the last sentence with my non native english parser. "vma" is array would make sense. > > Fixes: 6b05030496f7 ("drm/i915: Convert i915_gem_object/client_blt.c to use ww locking as well, v2.") > Signed-off-by: Dan Carpenter Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gem/i915_gem_object_blt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c b/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c > index d93eb36160c9..aee7ad3cc3c6 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c > @@ -364,7 +364,7 @@ int i915_gem_object_copy_blt(struct drm_i915_gem_object *src, > > vma[1] = i915_vma_instance(dst, vm, NULL); > if (IS_ERR(vma[1])) > - return PTR_ERR(vma); > + return PTR_ERR(vma[1]); > > i915_gem_ww_ctx_init(&ww, true); > intel_engine_pm_get(ce->engine); > -- > 2.28.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44840C433E2 for ; Thu, 10 Sep 2020 20:15:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F39BF20731 for ; Thu, 10 Sep 2020 20:15:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F39BF20731 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6B7D16E1A2; Thu, 10 Sep 2020 20:15:31 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5C3806E1A2 for ; Thu, 10 Sep 2020 20:15:30 +0000 (UTC) IronPort-SDR: NuVov6pF72wORTt/8HXE0wQmtLqcree4HFojLWv6dFM2WoSHPleq1/DnEw3dBnSEdVixR3FjnG ejAS2a7ZBbVQ== X-IronPort-AV: E=McAfee;i="6000,8403,9740"; a="146347636" X-IronPort-AV: E=Sophos;i="5.76,413,1592895600"; d="scan'208";a="146347636" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2020 13:15:29 -0700 IronPort-SDR: iU6WmuOj95tuXMN26AGlY7HXvpF8obhUT7eQhJ3dBd8gVzrQmms8A+R9ll83FSqYnZAG3XY3rg yfVLm9vNee/w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,413,1592895600"; d="scan'208";a="342053032" Received: from gaia.fi.intel.com ([10.237.72.192]) by FMSMGA003.fm.intel.com with ESMTP; 10 Sep 2020 13:15:25 -0700 Received: by gaia.fi.intel.com (Postfix, from userid 1000) id 6677A5C2042; Thu, 10 Sep 2020 23:14:19 +0300 (EEST) From: Mika Kuoppala To: Dan Carpenter , Jani Nikula , Maarten Lankhorst In-Reply-To: <20200910100850.GD79916@mwanda> References: <20200910100850.GD79916@mwanda> Date: Thu, 10 Sep 2020 23:14:19 +0300 Message-ID: <87363p4cf8.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix an error code i915_gem_object_copy_blt() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , kernel-janitors@vger.kernel.org, intel-gfx@lists.freedesktop.org, Chris Wilson , Matthew Auld Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Dan Carpenter writes: > This code should use "vma[1]" instead of "vma". The "vma" is a variable > is a valid pointer. Not quite getting the last sentence with my non native english parser. "vma" is array would make sense. > > Fixes: 6b05030496f7 ("drm/i915: Convert i915_gem_object/client_blt.c to use ww locking as well, v2.") > Signed-off-by: Dan Carpenter Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gem/i915_gem_object_blt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c b/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c > index d93eb36160c9..aee7ad3cc3c6 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c > @@ -364,7 +364,7 @@ int i915_gem_object_copy_blt(struct drm_i915_gem_object *src, > > vma[1] = i915_vma_instance(dst, vm, NULL); > if (IS_ERR(vma[1])) > - return PTR_ERR(vma); > + return PTR_ERR(vma[1]); > > i915_gem_ww_ctx_init(&ww, true); > intel_engine_pm_get(ce->engine); > -- > 2.28.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx