From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Justin Capella <justincapella@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless <linux-wireless@vger.kernel.org>,
make-wifi-fast@lists.bufferbloat.net, nbd@nbd.name,
Yibo Zhao <yiboz@codeaurora.org>, John Crispin <john@phrozen.org>,
lorenzo@kernel.org, rmanohar@codeaurora.org,
kevinhayes@google.com, Kan Yan <kyan@google.com>
Subject: Re: [PATCH v11 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue
Date: Thu, 27 Feb 2020 11:17:05 +0100 [thread overview]
Message-ID: <8736awxrku.fsf@toke.dk> (raw)
In-Reply-To: <CAMrEMU8FkUkoTB95K8cbBgcrUBPmE0cy6yUcROLTw1_BuSCKuQ@mail.gmail.com>
Justin Capella <justincapella@gmail.com> writes:
>> ieee80211_report_used_skb(). As an optimisation, we also subtract the
>> airtime on regular TX completion, zeroing out the value stored in the
>> packet afterwards, to avoid having to do an expensive lookup of the station
>> from the packet data on every packet.
>>
>> This patch does *not* include any mechanism to wake a throttled TXQ again,
>> on the assumption that this will happen anyway as a side effect of whatever
>> freed the skb (most commonly a TX completion).
>
> I recall a recent patch for ath10k sdio that disabled tx
> acknowledgement for performance gains and am wondering if that will be
> problematic? Presumably not since it would be caught at the dequeue,
> but thought I'd ask-- wondering what the effect of failed tx's or
> block acknowledgement is on this stuff I'll need to study the code
> some more
>
> https://lore.kernel.org/linux-wireless/0101016eb1903db0-ef7063b4-0f42-4a01-8886-327541e6c1a4-000000@us-west-2.amazonses.com/T/#t
It looks like that patch will just end up disabling AQL (because packets
will be immediately completed as far as mac80211 is concerned) and
replace it with whatever that credit-based scheme does? No idea how that
will impact latency; you should go ask the developers of that series! As
usual, the patch description only mentions throughput numbers :/
-Toke
prev parent reply other threads:[~2020-02-27 10:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 6:06 [PATCH v11 0/4] Add Airtime Queue Limits (AQL) to mac80211 Kan Yan
2019-11-19 6:06 ` [PATCH v11 1/4] mac80211: Add new sta_info getter by sta/vif addrs Kan Yan
2019-11-19 6:06 ` [PATCH v11 2/4] mac80211: Import airtime calculation code from mt76 Kan Yan
2019-11-22 12:12 ` Johannes Berg
2019-11-22 12:56 ` Toke Høiland-Jørgensen
2019-11-22 13:00 ` Johannes Berg
2019-11-22 13:11 ` Toke Høiland-Jørgensen
2019-11-22 13:15 ` Johannes Berg
2019-11-22 14:41 ` Toke Høiland-Jørgensen
2019-11-22 12:27 ` Johannes Berg
2019-11-22 12:56 ` Toke Høiland-Jørgensen
2019-11-19 6:06 ` [PATCH v11 3/4] mac80211: Implement Airtime-based Queue Limit (AQL) Kan Yan
2019-11-19 6:06 ` [PATCH v11 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue Kan Yan
2020-02-26 20:30 ` Felix Fietkau
2020-02-26 21:56 ` Toke Høiland-Jørgensen
2020-02-27 8:24 ` Kan Yan
2020-02-27 10:42 ` Felix Fietkau
2020-02-27 11:07 ` Toke Høiland-Jørgensen
2020-02-27 12:00 ` Felix Fietkau
2020-02-27 8:34 ` Felix Fietkau
2020-02-27 10:07 ` Toke Høiland-Jørgensen
2020-02-27 11:34 ` Felix Fietkau
2020-02-27 11:59 ` Toke Høiland-Jørgensen
2020-02-27 9:25 ` Justin Capella
2020-02-27 10:17 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736awxrku.fsf@toke.dk \
--to=toke@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=john@phrozen.org \
--cc=justincapella@gmail.com \
--cc=kevinhayes@google.com \
--cc=kyan@google.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=nbd@nbd.name \
--cc=rmanohar@codeaurora.org \
--cc=yiboz@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.