From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F450C5ACC4 for ; Thu, 20 Feb 2020 03:02:17 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03B29206E2 for ; Thu, 20 Feb 2020 03:02:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="cMB/f2s+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03B29206E2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3E10E1698; Thu, 20 Feb 2020 04:01:25 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3E10E1698 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1582167735; bh=bglizIMAC/xlBJD1uZqOTl5FW4kjdeoEeQrZZJAG2NA=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=cMB/f2s+1Ov7og6zA/goYUm3Rd4LLIVmOhRqHsQhE2jsU1ibAGe1uq38iVN9hiVjP zDpTDQ4UKnkNo91POY1s3RlO4Kr+22uRGpTkqap9SGeM+P+g7iopkLpmYKMlH7XGl9 /rlbq9+v7RG+7K/0LfXv/hMZtPPKhFl6mkUn1fNs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B3C3BF80145; Thu, 20 Feb 2020 04:01:24 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 40345F80148; Thu, 20 Feb 2020 04:01:22 +0100 (CET) Received: from relmlie6.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by alsa1.perex.cz (Postfix) with ESMTP id 07B1FF8011D for ; Thu, 20 Feb 2020 04:01:16 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 07B1FF8011D Date: 20 Feb 2020 12:01:13 +0900 X-IronPort-AV: E=Sophos;i="5.70,462,1574089200"; d="scan'208";a="39555475" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie6.idc.renesas.com with ESMTP; 20 Feb 2020 12:01:13 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id 5B0E64133BF1; Thu, 20 Feb 2020 12:01:13 +0900 (JST) Message-ID: <8736b6t120.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: "Sridharan, Ranjani" Subject: Re: [PATCH][RFC] ASoC: soc-component: count snd_soc_component_open/close() In-Reply-To: References: <20200219182650.1416-1-kai.vehmanen@linux.intel.com> <87blput7hh.wl-kuninori.morimoto.gx@renesas.com> <878skyt6om.wl-kuninori.morimoto.gx@renesas.com> <875zg2t4qd.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/25.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: Linux-ALSA , Kai Vehmanen , Ranjani Sridharan , Pierre-Louis Bossart , Mark Brown , digetx@gmail.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Sridharan > > ASoC component open/close and snd_soc_component_module_get/put are > > called once for each component, but we need it for each substream. > > To solve this issue, this patch counts open / get, > > and call close / put accordingly. > > > > Fixes: dd03907bf129 ("ASoC: soc-pcm: call snd_soc_component_open/close() once") > > Reported-by: Kai Vehmanen > > Signed-off-by: Kuninori Morimoto > > --- (snip) > I think same as open ? > It protects calling put() from not-get-component. > Because module_put() has WARN_ON(ret < 0). > > Can we use the module_refcount instead of adding a new field? Ahh, maybe yes. I can try to use it in non-RFC patch. Thank you for your help !! Best regards --- Kuninori Morimoto