From: Michael Ellerman <mpe@ellerman.id.au>
To: Nicholas Piggin <npiggin@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [PATCH 1/2] powerpc/64s: remplement power4_idle code in C
Date: Sun, 18 Aug 2019 13:49:03 +1000 [thread overview]
Message-ID: <8736hz6sls.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20190711022404.18132-1-npiggin@gmail.com>
Nicholas Piggin <npiggin@gmail.com> writes:
> diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S
> index eee5bef736c8..64d5ffbb07d1 100644
> --- a/arch/powerpc/kernel/exceptions-64s.S
> +++ b/arch/powerpc/kernel/exceptions-64s.S
> @@ -2286,15 +2286,6 @@ USE_FIXED_SECTION(virt_trampolines)
> __end_interrupts:
> DEFINE_FIXED_SYMBOL(__end_interrupts)
>
> -#ifdef CONFIG_PPC_970_NAP
> -EXC_COMMON_BEGIN(power4_fixup_nap)
> - andc r9,r9,r10
> - std r9,TI_LOCAL_FLAGS(r11)
> - ld r10,_LINK(r1) /* make idle task do the */
> - std r10,_NIP(r1) /* equivalent of a blr */
> - blr
> -#endif
This breaks ppc64_defconfig build with:
ERROR: start_text address is c000000000008100, should be c000000000008000
Due to:
c000000000008000 <0000001a.long_branch.power4_fixup_nap>:
c000000000008000: 48 03 5a b4 b c00000000003dab4 <power4_fixup_nap>
Moving power4_fixup_nap back into exceptions-64s.S seems to fix it.
cheers
next prev parent reply other threads:[~2019-08-18 3:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 2:24 [PATCH 1/2] powerpc/64s: remplement power4_idle code in C Nicholas Piggin
2019-07-11 2:24 ` [PATCH 2/2] powerpc/64s: Remove idle workaround code from restore_cpu_cpufeatures Nicholas Piggin
2019-08-18 3:49 ` Michael Ellerman [this message]
2019-08-19 13:07 ` [PATCH 1/2] powerpc/64s: remplement power4_idle code in C Nicholas Piggin
2020-01-29 5:17 ` Michael Ellerman
2020-12-15 10:49 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736hz6sls.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.