From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12DD5C28CC5 for ; Wed, 5 Jun 2019 17:54:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF17B206C3 for ; Wed, 5 Jun 2019 17:54:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF17B206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:47904 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYa7P-0003JM-PE for qemu-devel@archiver.kernel.org; Wed, 05 Jun 2019 13:54:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYa6e-00032W-Vh for qemu-devel@nongnu.org; Wed, 05 Jun 2019 13:53:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYa6e-00088n-0a for qemu-devel@nongnu.org; Wed, 05 Jun 2019 13:53:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48362) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hYa6c-00086e-L3 for qemu-devel@nongnu.org; Wed, 05 Jun 2019 13:53:47 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 35E22309264D; Wed, 5 Jun 2019 17:53:13 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-148.ams2.redhat.com [10.36.116.148]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5C5D95C582; Wed, 5 Jun 2019 17:52:52 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C96AD11386A0; Wed, 5 Jun 2019 19:52:50 +0200 (CEST) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= References: <87lfyqla7r.fsf@dusky.pond.sub.org> <20190605142300.GB8956@redhat.com> Date: Wed, 05 Jun 2019 19:52:50 +0200 In-Reply-To: <20190605142300.GB8956@redhat.com> ("Daniel P. =?utf-8?Q?Berr?= =?utf-8?Q?ang=C3=A9=22's?= message of "Wed, 5 Jun 2019 15:23:00 +0100") Message-ID: <8736knnclp.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Wed, 05 Jun 2019 17:53:44 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] Headers without multiple inclusion guards X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Dmitry Fleytman , Sagar Karandikar , "Michael S. Tsirkin" , James Hogan , Anthony Green , Palmer Dabbelt , Mark Cave-Ayland , qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Guan Xuetao , Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Helge Deller , David Hildenbrand , Halil Pasic , Christian Borntraeger , Anthony Perard , David Gibson , Laszlo Ersek , Jason Wang , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Alistair Francis , Eduardo Habkost , Riku Voipio , Greg Kurz , Marcelo Tosatti , Beniamino Galvani , Eric Auger , Paul Durrant , Stafford Horne , Alex =?utf-8?Q?Benn=C3=A9e?= , Richard Henderson , Claudio Fontana , Bastian Koppelmann , Chris Wulff , Claudio Fontana , Laurent Vivier , Andrew Baumann , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Michael Walle , Aleksandar Markovic , Cornelia Huck , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Daniel P. Berrang=C3=A9 writes: > On Tue, May 28, 2019 at 08:12:24PM +0200, Markus Armbruster wrote: >> We have a bunch of headers without multiple inclusion guards. Some are >> clearly intentional, some look accidental. Too many for me to find out >> by examining each of them, so I'm asking their maintainers. >>=20 >> Why do I ask? I'd like to mark the intentional ones and fix the >> accidental ones, so they don't flunk "make check-headers" from "[RFC v4 >> 0/7] Baby steps towards saner headers" just because they lack multiple >> inclusion guards. >>=20 >> Just in case: what's a multiple inclusion guard? It's >>=20 >> #ifndef UNIQUE_GUARD_SYMBOL_H >> #define UNIQUE_GUARD_SYMBOL_H >> ... >> #endif >>=20 >> with nothing but comments outside the conditional, so that the header >> can safely be included more than once. > > Any opinions on using the less verbose syntax instead: > > #pragma once > > It is not portable C, but we explicitly only care about GCC or CLang, > so portability isn't an issue for us. I doubt its worth the churn. But I'm content to go with the flow here. >> Cryptography >> M: Daniel P. Berrange >> crypto/ivgen-essiv.h >> crypto/ivgen-plain.h >> crypto/ivgen-plain64.h > > These have header guards present Yes. They #include outside the header guard, which confuses my script. >> tests/crypto-tls-psk-helpers.h >> tests/crypto-tls-x509-helpers.h > > These should be fixed. Will do, thanks!