From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2170C282DD for ; Thu, 23 May 2019 20:59:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5A3B2081C for ; Thu, 23 May 2019 20:59:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730866AbfEWU7b (ORCPT ); Thu, 23 May 2019 16:59:31 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:41507 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726222AbfEWU7a (ORCPT ); Thu, 23 May 2019 16:59:30 -0400 Received: from in02.mta.xmission.com ([166.70.13.52]) by out02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1hTuoD-0007Zz-12; Thu, 23 May 2019 14:59:29 -0600 Received: from ip72-206-97-68.om.om.cox.net ([72.206.97.68] helo=x220.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1hTuoC-0001Ok-66; Thu, 23 May 2019 14:59:28 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Will Deacon Cc: linux-kernel@vger.kernel.org, Linux Containers , Oleg Nesterov , linux-arch@vger.kernel.org, Dave Martin , James Morse References: <20190523003916.20726-1-ebiederm@xmission.com> <20190523003916.20726-4-ebiederm@xmission.com> <20190523101702.GG26646@fuggles.cambridge.arm.com> <875zq1gnh4.fsf_-_@xmission.com> <20190523161509.GE31896@fuggles.cambridge.arm.com> Date: Thu, 23 May 2019 15:59:20 -0500 In-Reply-To: <20190523161509.GE31896@fuggles.cambridge.arm.com> (Will Deacon's message of "Thu, 23 May 2019 17:15:09 +0100") Message-ID: <8736l4evkn.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1hTuoC-0001Ok-66;;;mid=<8736l4evkn.fsf@xmission.com>;;;hst=in02.mta.xmission.com;;;ip=72.206.97.68;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1+Z3RJpqVzsp/miFmNUMgwL6TRBDa41ahw= X-SA-Exim-Connect-IP: 72.206.97.68 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [REVIEW][PATCHv2 03/26] signal/arm64: Use force_sig not force_sig_fault for SIGKILL X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Will Deacon writes: > On Thu, May 23, 2019 at 11:11:19AM -0500, Eric W. Biederman wrote: >> diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c >> index ade32046f3fe..e45d5b440fb1 100644 >> --- a/arch/arm64/kernel/traps.c >> +++ b/arch/arm64/kernel/traps.c >> @@ -256,7 +256,10 @@ void arm64_force_sig_fault(int signo, int code, void __user *addr, >> const char *str) >> { >> arm64_show_signal(signo, str); >> - force_sig_fault(signo, code, addr, current); >> + if (signo == SIGKILL) >> + force_sig(SIGKILL, current); >> + else >> + force_sig_fault(signo, code, addr, current); >> } > > Acked-by: Will Deacon > > Are you planning to send this series on, or would you like me to pick this > into the arm64 tree? I am planning on taking this through siginfo tree, unless it causes problems. The rest of my patchset this is a part of is a clean up to remove the task pointer which is always current from all of the force_sig calls. Eric