From: Fabiano Rosas <farosas@linux.ibm.com>
To: Shivaprasad G Bhat <sbhat@linux.ibm.com>,
imammedo@redhat.com, david@gibson.dropbear.id.au,
xiaoguangrong.eric@gmail.com, mst@redhat.com
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, sbhat@linux.ibm.com
Subject: Re: [Qemu-devel] [RFC v2 PATCH 3/3] spapr: Add Hcalls to support PAPR NVDIMM device
Date: Wed, 22 May 2019 15:11:23 -0300 [thread overview]
Message-ID: <8736l65ph0.fsf@linux.ibm.com> (raw)
In-Reply-To: <875zq25plp.fsf@linux.ibm.com>
Fabiano Rosas <farosas@linux.ibm.com> writes:
>> + nvdimm = NVDIMM(drc->dev);
>> + if ((offset + numBytesToRead < offset) ||
>> + (nvdimm->label_size < numBytesToRead + offset)) {
>> + return H_P2;
>> + }
>
> Won't the first clause always be false? Considering they're both uint64_t.
Neverming this question. I just saw that David asked for it in the previous
version.
next prev parent reply other threads:[~2019-05-22 18:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 9:25 [Qemu-devel] [RFC v2 PATCH 0/3] ppc: spapr: virtual NVDIMM support Shivaprasad G Bhat
2019-05-13 9:27 ` [Qemu-devel] [RFC v2 PATCH 1/3] mem: make nvdimm_device_list global Shivaprasad G Bhat
2019-05-13 9:28 ` [Qemu-devel] [RFC v2 PATCH 2/3] spapr: Add NVDIMM device support Shivaprasad G Bhat
2019-05-14 2:22 ` David Gibson
2019-05-15 7:00 ` Shivaprasad G Bhat
2019-05-16 1:32 ` David Gibson
2019-05-17 7:42 ` Shivaprasad G Bhat
2019-05-22 16:07 ` Fabiano Rosas
2019-07-16 7:53 ` Shivaprasad G Bhat
2019-05-13 9:28 ` [Qemu-devel] [RFC v2 PATCH 3/3] spapr: Add Hcalls to support PAPR NVDIMM device Shivaprasad G Bhat
2019-05-14 4:38 ` David Gibson
2019-07-11 5:46 ` Shivaprasad G Bhat
2019-05-22 18:08 ` Fabiano Rosas
2019-05-22 18:11 ` Fabiano Rosas [this message]
2019-05-23 0:46 ` David Gibson
2019-07-11 5:51 ` Shivaprasad G Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736l65ph0.fsf@linux.ibm.com \
--to=farosas@linux.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sbhat@linux.ibm.com \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.