From: "Bjørn Mork" <bjorn@mork.no>
To: "Jörgen Storvist" <jorgen.storvist@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2] qmi_wwan: Added support for Fibocom NL668 series
Date: Tue, 11 Dec 2018 15:12:05 +0100 [thread overview]
Message-ID: <8736r4m9u2.fsf@miraculix.mork.no> (raw)
In-Reply-To: <20181211144914.00004760@gmail.com> (=?utf-8?Q?=22J=C3=B6rgen?= Storvist"'s message of "Tue, 11 Dec 2018 14:49:14 +0100")
Jörgen Storvist <jorgen.storvist@gmail.com> writes:
> Should be correct now as above if I understood you correctly.
Yup, the sorting part looks fine. But you need to drop the additional
text below the patch. It will mess up the result. Any extra text which
isn't part of the patch or the commit message should go inside the ---
markers, like you correctly did with the changelog.
It's also possible to use "scissors" to separate extra text from the
patch, but this is rarely used. Ref https://kernelnewbies.org/PatchTipsAndTricks
Bjørn
next prev parent reply other threads:[~2018-12-11 14:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-09 22:57 [PATCH] qmi_wwan: Added support for Fibocom NL668 series Jörgen Storvist
2018-12-10 13:52 ` Bjørn Mork
2018-12-11 13:49 ` [PATCH v2] " Jörgen Storvist
2018-12-11 14:12 ` Bjørn Mork [this message]
2018-12-11 15:49 ` [PATCH v3] " Jörgen Storvist
2018-12-11 20:56 ` Bjørn Mork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736r4m9u2.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=jorgen.storvist@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.