All of lore.kernel.org
 help / color / mirror / Atom feed
From: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
To: OpenEmbedded Devel List <openembedded-devel@lists.openembedded.org>
Cc: Otavio Salvador <otavio.salvador@ossystems.com.br>
Subject: Re: [meta-browser] CFT: Chromium 62 in meta-browser
Date: Thu, 09 Nov 2017 18:08:15 +0100	[thread overview]
Message-ID: <87375nbcsg.fsf@rkubodac-desk.ger.corp.intel.com> (raw)
In-Reply-To: <CAP9ODKrE_NpWXKR8mZ=y3pa0A4DLd9a7iLE7dVK1RgoUVK1SuA@mail.gmail.com> (Otavio Salvador's message of "Thu, 9 Nov 2017 14:54:39 -0200")

Hey Otavio, thanks for the quick response!

Otavio Salvador <otavio.salvador@ossystems.com.br> writes:
> Hello Raphael,
>
>> I'd like people to look at my commits and let me know if there's any big
>> issue that would prevent those changes from landing into meta-browser.
>> If everything's OK, I'd then start sending the patches to the list (or
>> pull requests on GitHub, whichever is preferred).
>
> I went through all the commits, one by one. There are few that might
> need minor adjustments (as for example the removal of cups support
> which should be moved to a PACKAGECONFIG) but in general, they are all
> good. You did a great job making it very granular and well documented
> :-)
>
> I think this is huge enough that using a pull request so we can track
> comments and progress makes sense. Do you mind creating one?
>
> I think we will end picking individual commits on the beginning to
> reduce the delta and keep going until we have the bump done. Do you
> think it is a good way to handle this?

I think that works, and it matches what I originally had in mind:
* Get people to look at the existing commits and raise any objections to
  any major "architectural" issues with the changes.
* Once everyone's on the same page, start sending patches in chunks
  (e.g. all dependency changes in one pull request).
* Once the clean-ups and bug fixes are in, send the big PRs (move to GN
  and update to M62).

I'll start splitting that branch into smaller ones for PRs, but I'll
also wait a little bit for others (such as Jacobo, Trevor and Khem) to
chime in as well.

The only bummer is that I'll be on holidays from 17th November to 8th
December so it may take a little longer than usual for me to get all the
changes landed.


  reply	other threads:[~2017-11-09 17:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-09 16:28 [meta-browser] CFT: Chromium 62 in meta-browser Raphael Kubo da Costa
2017-11-09 16:54 ` Otavio Salvador
2017-11-09 17:08   ` Raphael Kubo da Costa [this message]
2017-11-10 19:49 ` Trevor Woerner
2017-11-11  0:10   ` Ian Coolidge
2017-11-11 17:25     ` Otavio Salvador
2017-11-13 21:51       ` Ian Coolidge
2017-11-13 21:56         ` Ian Coolidge
2017-11-15 12:04 ` Raphael Kubo da Costa
2017-11-15 12:38   ` Martin Jansa
2017-11-15 14:20     ` Martin Jansa
2017-11-15 17:08     ` Raphael Kubo da Costa
2017-11-15 17:41       ` Martin Jansa
2017-11-15 17:49         ` Kubo Da Costa, Raphael
2017-11-15 19:34         ` Khem Raj
2017-11-23 10:22           ` Ayoub Zaki
2017-11-28  0:52             ` Ian Coolidge
2017-11-28  8:13               ` Ayoub Zaki
2017-11-28 11:58                 ` Otavio Salvador
2017-11-28 12:47                   ` Ayoub Zaki
2017-11-28 13:05                     ` Otavio Salvador
2017-11-28 21:44                       ` Ian Coolidge
2017-12-11 11:30             ` Raphael Kubo da Costa
2017-12-11 11:35               ` Ayoub Zaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87375nbcsg.fsf@rkubodac-desk.ger.corp.intel.com \
    --to=raphael.kubo.da.costa@intel.com \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=otavio.salvador@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.