From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 2/4] drm/i915: Report back whether the irq was armed when adding the waiter Date: Thu, 08 Jun 2017 13:12:18 +0300 Message-ID: <8737badbzx.fsf@gaia.fi.intel.com> References: <20170605102619.4679-1-chris@chris-wilson.co.uk> <20170605102619.4679-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA8F86E381 for ; Thu, 8 Jun 2017 10:12:39 +0000 (UTC) In-Reply-To: <20170605102619.4679-2-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gVGhlIGlt cG9ydGFudCBjb25kaXRpb24gdGhhdCB3ZSBuZWVkIHRvIGNoZWNrIGFmdGVyIGVuYWJsaW5nIHRo ZQo+IGludGVycnVwdCBmb3Igc2lnbmFsaW5nIGlzIHdoZXRoZXIgdGhlIHJlcXVlc3QgY29tcGxl dGVkIGluIHRoZSBwcm9jZXNzCj4gKGFuZCBzbyB3ZSBtaXNzZWQgdGhhdCBpbnRlcnJ1cHQpLiBB IGxhcmdlIGNvc3QgaW4gZW5hYmxpbmcgdGhlCj4gc2lnbmFsaW5nIChyYXRoZXIgdGhhbiB3YWl0 ZXJzKSBpcyBpbiB3YWtpbmcgdXAgdGhlIGF1eGlsaWFyeSBzaWduYWxpbmcKPiB0aHJlYWQsIGJ1 dCB3ZSBvbmx5IG5lZWQgdG8gZG8gc28gdG8gY2F0Y2ggdGhhdCBtaXNzZWQgaW50ZXJydXB0LiBJ ZiB3ZQo+IGtub3cgd2UgZGlkbid0IG1pc3MgYW55IGludGVycnVwdHMgKGJlY2F1c2Ugd2UgZGlk bid0IGFybSB0aGUgaW50ZXJydXB0KQo+IHRoZW4gd2UgY2FuIHNraXAgd2FraW5nIHRoZSBhdXhp bGlhcnkgdGhyZWFkLgo+Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJp cy13aWxzb24uY28udWs+Cj4gQ2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxp bnV4LmludGVsLmNvbT4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVs LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYnJlYWRjcnVtYnMuYyB8 IDE2ICsrKysrKysrKysrLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyks IDUgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfYnJlYWRjcnVtYnMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2JyZWFkY3J1bWJz LmMKPiBpbmRleCAxODNhZmNiMDM2YWEuLmRiY2FkOWY2YjJkNSAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9icmVhZGNydW1icy5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfYnJlYWRjcnVtYnMuYwo+IEBAIC0zMjksNyArMzI5LDcgQEAgc3RhdGlj IGJvb2wgX19pbnRlbF9lbmdpbmVfYWRkX3dhaXQoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5n aW5lLAo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfYnJlYWRjcnVtYnMgKmIgPSAmZW5naW5lLT5icmVh ZGNydW1iczsKPiAgCXN0cnVjdCByYl9ub2RlICoqcCwgKnBhcmVudCwgKmNvbXBsZXRlZDsKPiAt CWJvb2wgZmlyc3Q7Cj4gKwlib29sIGZpcnN0LCBpcnFfYXJtZWQ7Cj4gIAl1MzIgc2Vxbm87Cj4g IAo+ICAJLyogSW5zZXJ0IHRoZSByZXF1ZXN0IGludG8gdGhlIHJldGlyZW1lbnQgb3JkZXJlZCBs aXN0Cj4gQEAgLTM0NCw2ICszNDQsNyBAQCBzdGF0aWMgYm9vbCBfX2ludGVsX2VuZ2luZV9hZGRf d2FpdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gIAkgKiByZW1vdmluZyBzdGFs ZSBlbGVtZW50cyBpbiB0aGUgdHJlZSwgd2UgbWF5IGJlIGFibGUgdG8gcmVkdWNlIHRoZQo+ICAJ ICogcGluZy1wb25nIGJldHdlZW4gdGhlIG9sZCBib3R0b20taGFsZiBhbmQgb3Vyc2VsdmVzIGFz IGZpcnN0LXdhaXRlci4KPiAgCSAqLwo+ICsJaXJxX2FybWVkID0gZmFsc2U7Cj4gIAlmaXJzdCA9 IHRydWU7Cj4gIAlwYXJlbnQgPSBOVUxMOwo+ICAJY29tcGxldGVkID0gTlVMTDsKPiBAQCAtMzkw LDYgKzM5MSw3IEBAIHN0YXRpYyBib29sIF9faW50ZWxfZW5naW5lX2FkZF93YWl0KHN0cnVjdCBp bnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwKPiAgCj4gIAlpZiAoZmlyc3QpIHsKPiAgCQlzcGluX2xv Y2soJmItPmlycV9sb2NrKTsKPiArCQlpcnFfYXJtZWQgPSAhYi0+aXJxX2FybWVkOwoKVGhpcyBj b3VsZCB1c2UgYSBjb21tZW50LgoKPiAgCQliLT5pcnFfd2FpdCA9IHdhaXQ7Cj4gIAkJLyogQWZ0 ZXIgYXNzaWduaW5nIG91cnNlbHZlcyBhcyB0aGUgbmV3IGJvdHRvbS1oYWxmLCB3ZSBtdXN0Cj4g IAkJICogcGVyZm9ybSBhIGN1cnNvcnkgY2hlY2sgdG8gcHJldmVudCBhIG1pc3NlZCBpbnRlcnJ1 cHQuCj4gQEAgLTQyNiwyMCArNDI4LDI0IEBAIHN0YXRpYyBib29sIF9faW50ZWxfZW5naW5lX2Fk ZF93YWl0KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwKPiAgCUdFTV9CVUdfT04oIWIt PmlycV9hcm1lZCk7Cj4gIAlHRU1fQlVHX09OKHJiX2ZpcnN0KCZiLT53YWl0ZXJzKSAhPSAmYi0+ aXJxX3dhaXQtPm5vZGUpOwo+ICAKPiAtCXJldHVybiBmaXJzdDsKPiArCXJldHVybiBpcnFfYXJt ZWQ7Cj4gIH0KPiAgCj4gIGJvb2wgaW50ZWxfZW5naW5lX2FkZF93YWl0KHN0cnVjdCBpbnRlbF9l bmdpbmVfY3MgKmVuZ2luZSwKPiAgCQkJICAgc3RydWN0IGludGVsX3dhaXQgKndhaXQpCj4gIHsK PiAgCXN0cnVjdCBpbnRlbF9icmVhZGNydW1icyAqYiA9ICZlbmdpbmUtPmJyZWFkY3J1bWJzOwo+ IC0JYm9vbCBmaXJzdDsKPiArCWJvb2wgaXJxX2FybWVkOwo+ICAKPiAgCXNwaW5fbG9ja19pcnEo JmItPnJiX2xvY2spOwo+IC0JZmlyc3QgPSBfX2ludGVsX2VuZ2luZV9hZGRfd2FpdChlbmdpbmUs IHdhaXQpOwo+ICsJaXJxX2FybWVkID0gX19pbnRlbF9lbmdpbmVfYWRkX3dhaXQoZW5naW5lLCB3 YWl0KTsKPiAgCXNwaW5fdW5sb2NrX2lycSgmYi0+cmJfbG9jayk7Cj4gKwlpZiAoaXJxX2FybWVk KQo+ICsJCXJldHVybiBpcnFfYXJtZWQ7Cj4gIAo+IC0JcmV0dXJuIGZpcnN0Owo+ICsJLyogTWFr ZSB0aGUgY2FsbGVyIHJlY2hlY2sgaWYgaXRzIHJlcXVlc3QgaGFzIGFscmVhZHkKPiBzdGFydGVk LiAqLwoKVGhpcyBjb3VsZCBiZSBsaWZ0ZWQgdG8gdGhlIGZ1bmN0aW9uIGRvY3VtZW50YXRpb24g dG8gZGVzY3JpYmUKd2hhdCB0aGUgcmV0dXJuIHZhbHVlIGFjdHVhbGx5IG1lYW5zLiBCdXQgSSBh bSBub3QgaW5zaXN0aW5nLgoKUmV2aWV3ZWQtYnk6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBh bGFAaW50ZWwuY29tPgoKPiArCXJldHVybiBpOTE1X3NlcW5vX3Bhc3NlZChpbnRlbF9lbmdpbmVf Z2V0X3NlcW5vKGVuZ2luZSksCj4gKwkJCQkgd2FpdC0+c2Vxbm8gLSAxKTsKPiAgfQo+ICAKPiAg c3RhdGljIGlubGluZSBib29sIGNoYWluX3dha2V1cChzdHJ1Y3QgcmJfbm9kZSAqcmIsIGludCBw cmlvcml0eSkKPiAtLSAKPiAyLjExLjAKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK