Re: [Qemu-devel] [PATCH v2 18/45] qdev: make default property int

[Markus Armbruster <armbru@redhat.com>]

Marc-André Lureau <marcandre.lureau@redhat.com> writes:

> The following patch will add uint properties.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

"Make default property int" doesn't make sense to me.  The patch does
two things:

1. Rename DEFINE_PROP_DEFAULT() to DEFINE_PROP_INT(), to prepare for the
next patch's DEFINE_PROP_UINT().

2. Wrap the Property default value (an int64_t) in a union, to prepare
for the next patch adding a uint64_t.

If you split the patch accordingly, the commit messages will write
themselves :)

I'd use DEFINE_PROP_SIGNED() to avoid misleading readers into making a
connection to type int, and DEFINE_PROP_UNSIGNED() to match.

Other than that, the patch looks good.