All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@savoirfairelinux.com,
	"David S. Miller" <davem@davemloft.net>,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next 4/7] net: dsa: free orig skb on rcv if reallocated
Date: Tue, 30 May 2017 11:41:51 -0400	[thread overview]
Message-ID: <8737bm4aio.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20170530152505.GG22758@lunn.ch>

Hi Andrew,

Andrew Lunn <andrew@lunn.ch> writes:

> On Tue, May 30, 2017 at 10:21:28AM -0400, Vivien Didelot wrote:
>> If the receive function of a tagger reallocated the SKB, the original
>> SKB is currently not freed. Fix this and free it on both copy or error.
>
> I don't see any of the receive functions reallocate the skb. It might
> be better to just simplify the code to take away the option to return
> a different skb.

I think it was written such way to be symmetrical with the xmit
implementation, where the trailer tagger does reallocate the skb.

I would say that keeping the symmetry is simpler from the point of view
of the tagging implementations, but I don't have strong opinion here.

Thanks,

        Vivien

  reply	other threads:[~2017-05-30 15:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-30 14:21 [PATCH net-next 0/7] net: dsa: tagger simplification Vivien Didelot
2017-05-30 14:21 ` [PATCH net-next 1/7] net: dsa: hide dsa_uses_tagged_protocol code Vivien Didelot
2017-05-30 15:01   ` Andrew Lunn
2017-05-30 15:09     ` David Miller
2017-05-30 15:56       ` Vivien Didelot
2017-05-30 16:12         ` Andrew Lunn
2017-05-30 16:14           ` Vivien Didelot
2017-05-30 21:08   ` kbuild test robot
2017-05-30 14:21 ` [PATCH net-next 2/7] net: dsa: remove useless rcv copy in DSA tree Vivien Didelot
2017-05-30 15:05   ` Andrew Lunn
2017-05-30 15:09     ` David Miller
2017-05-30 14:21 ` [PATCH net-next 3/7] net: dsa: remove unused arguments of tagger rcv Vivien Didelot
2017-05-30 15:13   ` Andrew Lunn
2017-05-30 14:21 ` [PATCH net-next 4/7] net: dsa: free orig skb on rcv if reallocated Vivien Didelot
2017-05-30 15:25   ` Andrew Lunn
2017-05-30 15:41     ` Vivien Didelot [this message]
2017-05-30 16:26       ` Andrew Lunn
2017-05-30 14:21 ` [PATCH net-next 5/7] net: dsa: remove useless goto label in tagger rcv Vivien Didelot
2017-05-30 14:21 ` [PATCH net-next 6/7] net: dsa: remove useless copy of tagger xmit Vivien Didelot
2017-05-30 15:29   ` Andrew Lunn
2017-05-30 15:43     ` Vivien Didelot
2017-05-30 14:21 ` [PATCH net-next 7/7] net: dsa: factor skb freeing on xmit Vivien Didelot
2017-05-30 15:37   ` Andrew Lunn
2017-05-30 15:08 ` [PATCH net-next 0/7] net: dsa: tagger simplification Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737bm4aio.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me \
    --to=vivien.didelot@savoirfairelinux.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@savoirfairelinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.