From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753513AbdDNSH0 (ORCPT ); Fri, 14 Apr 2017 14:07:26 -0400 Received: from anholt.net ([50.246.234.109]:46288 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751696AbdDNSHX (ORCPT ); Fri, 14 Apr 2017 14:07:23 -0400 From: Eric Anholt To: Boris Brezillon Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/vc4: Allow using more than 256MB of CMA memory. In-Reply-To: <20170414100825.254b8181@bbrezillon> References: <20170327231025.19391-1-eric@anholt.net> <20170414100825.254b8181@bbrezillon> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 14 Apr 2017 11:07:20 -0700 Message-ID: <8737da50dj.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Boris Brezillon writes: > On Mon, 27 Mar 2017 16:10:25 -0700 > Eric Anholt wrote: > >> Until now, we've had to limit Raspberry Pi to 256MB of CMA memory to >> keep from triggering the hardware addressing bug between of the tile >> binner of the tile alloc memory (where the top 4 bits come from the >> tile state data array's address). >>=20 >> To work around that and allow more memory to be reserved for graphics, >> allocate a single BO to store tile state data arrays and tile >> alloc/overflow memory while the GPU is active, and make sure that that >> one BO doesn't happen to cross a 256MB boundary. With that in place, >> we can allocate textures and shaders anywhere in system memory (still >> contiguous, of course). > > It's hard to review something I don't quite understand, but I didn't > spot any problem and the code seems to follow what the commit message > says: make sure the memory used by the tile binner (still have to look > at what a tile binner is :-)) does not cross a 256MB. > > So, not sure my review has a real value here, but > > Reviewed-by: Boris Brezillon It's still more review than vc4 patches used to get, so I'm happy. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAljxD9gACgkQtdYpNtH8 nug1xw/9GR/1mr2XJmn+/74YMCZMB3lO7rYX93iGXrAbmCbY0XQWVbjJO1VExcqp kdmESNZjLPiD2MtOaIvMZj12T7++EMkmOQ1WYGIaNqT6RNfJ0IBW38U3APYFjfBe 3ETS6/aXUq47/EkkYSDnWVdTK/kPRISRKoiSzPju0dRv1SM5hiSyz5A74sV+6tcS IWprf3dvq4C4/Qug5NJV5i2hVPwhiCdJe4GlzaNhN1U9CmEkZd/OndvkQIRhKV6u yVJLpjkpYhy+qoJ7Ru/C5HDivOg47hrCozISgT1DTqs3+h7JwhJFtoaWzCKi+UBM KjrCK/LOnbHNoCzE09McR8PfQKJdhwrCJ2VFN0D5xwUeIdvuUVpIP2BKcZvo+u9h R4Y+seBBqZkAxP/wSEjG+1a3M9ISznSpUczVFUUFIaXu3JJqmH42Ieg1nwZHipIM Yu4CQgq9FdEq6RPct4NCSKbEvmekfMEemxVkDs/wotE8dT9XcEk+8CiO2vd09Qun BtW12ixBNeqPnN43OR6mUpDPN/yRy0cH/ts96rE6Zwk/RlG9Lv8GROK0JmVjOSwm qm9zocnesD3pPLDd5dHCbyymM1FO9+5mHKgvHPikKLMhgNEKVXsE7drksyWs2pmh lYvcnADrh7OJg/L0UPiF2H+Fd+Wn0ZRhAnjUwduF3ycHgYRzsUM= =HVsd -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH] drm/vc4: Allow using more than 256MB of CMA memory. Date: Fri, 14 Apr 2017 11:07:20 -0700 Message-ID: <8737da50dj.fsf@eliezer.anholt.net> References: <20170327231025.19391-1-eric@anholt.net> <20170414100825.254b8181@bbrezillon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0538013381==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id EDCE76E9EF for ; Fri, 14 Apr 2017 18:07:22 +0000 (UTC) In-Reply-To: <20170414100825.254b8181@bbrezillon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Boris Brezillon Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0538013381== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Boris Brezillon writes: > On Mon, 27 Mar 2017 16:10:25 -0700 > Eric Anholt wrote: > >> Until now, we've had to limit Raspberry Pi to 256MB of CMA memory to >> keep from triggering the hardware addressing bug between of the tile >> binner of the tile alloc memory (where the top 4 bits come from the >> tile state data array's address). >>=20 >> To work around that and allow more memory to be reserved for graphics, >> allocate a single BO to store tile state data arrays and tile >> alloc/overflow memory while the GPU is active, and make sure that that >> one BO doesn't happen to cross a 256MB boundary. With that in place, >> we can allocate textures and shaders anywhere in system memory (still >> contiguous, of course). > > It's hard to review something I don't quite understand, but I didn't > spot any problem and the code seems to follow what the commit message > says: make sure the memory used by the tile binner (still have to look > at what a tile binner is :-)) does not cross a 256MB. > > So, not sure my review has a real value here, but > > Reviewed-by: Boris Brezillon It's still more review than vc4 patches used to get, so I'm happy. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAljxD9gACgkQtdYpNtH8 nug1xw/9GR/1mr2XJmn+/74YMCZMB3lO7rYX93iGXrAbmCbY0XQWVbjJO1VExcqp kdmESNZjLPiD2MtOaIvMZj12T7++EMkmOQ1WYGIaNqT6RNfJ0IBW38U3APYFjfBe 3ETS6/aXUq47/EkkYSDnWVdTK/kPRISRKoiSzPju0dRv1SM5hiSyz5A74sV+6tcS IWprf3dvq4C4/Qug5NJV5i2hVPwhiCdJe4GlzaNhN1U9CmEkZd/OndvkQIRhKV6u yVJLpjkpYhy+qoJ7Ru/C5HDivOg47hrCozISgT1DTqs3+h7JwhJFtoaWzCKi+UBM KjrCK/LOnbHNoCzE09McR8PfQKJdhwrCJ2VFN0D5xwUeIdvuUVpIP2BKcZvo+u9h R4Y+seBBqZkAxP/wSEjG+1a3M9ISznSpUczVFUUFIaXu3JJqmH42Ieg1nwZHipIM Yu4CQgq9FdEq6RPct4NCSKbEvmekfMEemxVkDs/wotE8dT9XcEk+8CiO2vd09Qun BtW12ixBNeqPnN43OR6mUpDPN/yRy0cH/ts96rE6Zwk/RlG9Lv8GROK0JmVjOSwm qm9zocnesD3pPLDd5dHCbyymM1FO9+5mHKgvHPikKLMhgNEKVXsE7drksyWs2pmh lYvcnADrh7OJg/L0UPiF2H+Fd+Wn0ZRhAnjUwduF3ycHgYRzsUM= =HVsd -----END PGP SIGNATURE----- --=-=-=-- --===============0538013381== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0538013381==--