From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD Date: Thu, 30 Mar 2017 17:37:55 -0700 Message-ID: <8737due0ws.fsf@eliezer.anholt.net> References: <20170126123728.5680-1-martin.peres@linux.intel.com> <155d45ba-503f-786d-943d-6ebc13fb2d82@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0733864733==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 994436E0DB for ; Fri, 31 Mar 2017 00:37:57 +0000 (UTC) In-Reply-To: <155d45ba-503f-786d-943d-6ebc13fb2d82@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Martin Peres , xorg-devel@lists.x.org Cc: Manasi Navare , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0733864733== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Martin Peres writes: > On 26/01/17 14:37, Martin Peres wrote: >> Despite all the careful planing of the kernel, a link may become >> insufficient to handle the currently-set mode. At this point, the >> kernel should mark this particular configuration as being broken >> and potentially prune the mode before setting the offending connector's >> link-status to BAD and send the userspace a hotplug event. This may >> happen right after a modeset or later on. >> >> When available, we should use the link-status information to reset >> the wanted mode. >> >> Signed-off-by: Martin Peres > > The relevant kernel patches have landed in drm-tip about a month ago. > > Eric, would you mind providing feedback on or merging this patch? The later discussion has sounded like the kernel will (always) prune the mode when we re-query, meaning that it doesn't make any sense to try to re-set to the old mode. Is this not the case? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAljdpOMACgkQtdYpNtH8 nuhoERAAtu149paBE0EbRwqRLmiswVxRgtfWqfIuj1jUZcDAnmx2JImGPV9LqEw5 l5nBfGMnRwFYYFMATHjtapCfxgaDLdcsHW6v+HGPxjyAzCZKbE9Klc21z9cTADdQ wVC2LgZd2GDRs8blTRHTetTlw0xIvOA65R8+SPLqMPB0W2xvY4jdUBoRryGFaQMU CRiPXSBqcLnoiKe+ad9Gl0wl23zWCk32rkij6eU6Nnm1OH0ogbj059OMSnTEVwA5 EadpuWIL55QDiM7gpraQtlypMX4t95Mw0Vfh27QvZAafkpdP4I+zhA6qnk6dfFPj E5Pu7IkgV9rN+WgYKu5peKw1FcshzTYv8elYeBKzcNGUaCQhnV1cJk8giO7vNmEy BF92kqpuFeFj2CuGZwfQ7mmwF7JnPkv63y07CGmb6UW72yMoF8T/RxlxG2Pcacws D4SGe3qED6BWtNXYW4pbBTaMJAovZagyMyC/MfY+JwwPI/tNv00MppsJDkuwpGL2 7VRrGynpqDV8yKVxvx/TS33JO70tZf6YnMxcoEmqMAPo8kFssv6cJrpbEeuVQwJV sThZ9oUBfHEeGhR99SgxXJwy5vf9Q+9WTSRMYBaqBuudagRE+Q7fw3vj3kRzM6cy Edzggr8ypkaf+SqeOXY7xfOnAJyCGYoOKa3p+3iuXStpfIQvbYI= =+iFc -----END PGP SIGNATURE----- --=-=-=-- --===============0733864733== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0733864733==--