From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:21837 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751671AbdBSOAA (ORCPT ); Sun, 19 Feb 2017 09:00:00 -0500 From: "Valo, Kalle" To: Erik Stromdahl CC: "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" Subject: Re: [RFC v3 0/8] ath10k sdio support Date: Sun, 19 Feb 2017 13:59:48 +0000 Message-ID: <8737fagu28.fsf@kamboji.qca.qualcomm.com> (sfid-20170219_150028_141809_4D54DFC4) References: <1484342771-6160-1-git-send-email-erik.stromdahl@gmail.com> <87fujbhb29.fsf@kamboji.qca.qualcomm.com> <1c87e0d1-1f14-08bb-2a69-650788fba8dc@gmail.com> <877f4ngii5.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <877f4ngii5.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Sun, 19 Feb 2017 01:57:06 +0200") Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Kalle Valo writes: > Erik Stromdahl writes: > >> I was actually about to email you about this. >> >> I have made a few more updates to the sdio code so I think it would be >> best if I could submit a new series of patches based on this code (v4). >> >> Then you can tweak it (v5). >> >> It is only minor updates to the HIF layer (added QCA9377 support) and >> a setup of some pll registers. > > Ok, that sounds good. I'll wait for v4. Forgot to mention can you run ath10k-check before submitting them, it shows few problems: https://wireless.wiki.kernel.org/en/users/drivers/ath10k/codingstyle#checki= ng_code But if you wonder what this is about it's checkpatch warning about camel case (doesn't like the lower case x character): drivers/net/wireless/ath/ath10k/sdio.h:68: I guess I have a bug in the script when it parses checkpatch output. --=20 Kalle Valo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cfS2H-0002Qo-E5 for ath10k@lists.infradead.org; Sun, 19 Feb 2017 14:00:23 +0000 From: "Valo, Kalle" Subject: Re: [RFC v3 0/8] ath10k sdio support Date: Sun, 19 Feb 2017 13:59:48 +0000 Message-ID: <8737fagu28.fsf@kamboji.qca.qualcomm.com> References: <1484342771-6160-1-git-send-email-erik.stromdahl@gmail.com> <87fujbhb29.fsf@kamboji.qca.qualcomm.com> <1c87e0d1-1f14-08bb-2a69-650788fba8dc@gmail.com> <877f4ngii5.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <877f4ngii5.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Sun, 19 Feb 2017 01:57:06 +0200") Content-Language: en-US MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Erik Stromdahl Cc: "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" Kalle Valo writes: > Erik Stromdahl writes: > >> I was actually about to email you about this. >> >> I have made a few more updates to the sdio code so I think it would be >> best if I could submit a new series of patches based on this code (v4). >> >> Then you can tweak it (v5). >> >> It is only minor updates to the HIF layer (added QCA9377 support) and >> a setup of some pll registers. > > Ok, that sounds good. I'll wait for v4. Forgot to mention can you run ath10k-check before submitting them, it shows few problems: https://wireless.wiki.kernel.org/en/users/drivers/ath10k/codingstyle#checking_code But if you wonder what this is about it's checkpatch warning about camel case (doesn't like the lower case x character): drivers/net/wireless/ath/ath10k/sdio.h:68: I guess I have a bug in the script when it parses checkpatch output. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k