* [PATCH v2] include: mman: Use bool instead of int for the return value of arch_validate_prot
@ 2016-07-24 3:43 chengang
2016-07-25 5:10 ` Michael Ellerman
0 siblings, 1 reply; 4+ messages in thread
From: chengang @ 2016-07-24 3:43 UTC (permalink / raw)
To: akpm, benh, paulus
Cc: mpe, dave.hansen, tglx, mingo, linuxppc-dev, linux-kernel,
Chen Gang, Chen Gang
From: Chen Gang <chengang@emindsoft.com.cn>
For pure bool function's return value, bool is a little better more or
less than int.
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
arch/powerpc/include/asm/mman.h | 8 ++++----
include/linux/mman.h | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/include/asm/mman.h b/arch/powerpc/include/asm/mman.h
index 2563c43..fc420ce 100644
--- a/arch/powerpc/include/asm/mman.h
+++ b/arch/powerpc/include/asm/mman.h
@@ -31,13 +31,13 @@ static inline pgprot_t arch_vm_get_page_prot(unsigned long vm_flags)
}
#define arch_vm_get_page_prot(vm_flags) arch_vm_get_page_prot(vm_flags)
-static inline int arch_validate_prot(unsigned long prot)
+static inline bool arch_validate_prot(unsigned long prot)
{
if (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM | PROT_SAO))
- return 0;
+ return false;
if ((prot & PROT_SAO) && !cpu_has_feature(CPU_FTR_SAO))
- return 0;
- return 1;
+ return false;
+ return true;
}
#define arch_validate_prot(prot) arch_validate_prot(prot)
diff --git a/include/linux/mman.h b/include/linux/mman.h
index 33e17f6..634c4c5 100644
--- a/include/linux/mman.h
+++ b/include/linux/mman.h
@@ -49,7 +49,7 @@ static inline void vm_unacct_memory(long pages)
*
* Returns true if the prot flags are valid
*/
-static inline int arch_validate_prot(unsigned long prot)
+static inline bool arch_validate_prot(unsigned long prot)
{
return (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM)) == 0;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] include: mman: Use bool instead of int for the return value of arch_validate_prot
2016-07-24 3:43 [PATCH v2] include: mman: Use bool instead of int for the return value of arch_validate_prot chengang
@ 2016-07-25 5:10 ` Michael Ellerman
2016-07-26 0:08 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Michael Ellerman @ 2016-07-25 5:10 UTC (permalink / raw)
To: chengang, akpm, benh, paulus
Cc: dave.hansen, tglx, mingo, linuxppc-dev, linux-kernel, Chen Gang,
Chen Gang
chengang@emindsoft.com.cn writes:
> From: Chen Gang <chengang@emindsoft.com.cn>
>
> For pure bool function's return value, bool is a little better more or
> less than int.
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> arch/powerpc/include/asm/mman.h | 8 ++++----
> include/linux/mman.h | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
LGTM.
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Andrew do you want to take this or should I?
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] include: mman: Use bool instead of int for the return value of arch_validate_prot
2016-07-25 5:10 ` Michael Ellerman
@ 2016-07-26 0:08 ` Andrew Morton
2016-07-26 1:15 ` Michael Ellerman
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2016-07-26 0:08 UTC (permalink / raw)
To: Michael Ellerman
Cc: chengang, benh, paulus, dave.hansen, tglx, mingo, linuxppc-dev,
linux-kernel, Chen Gang
On Mon, 25 Jul 2016 15:10:06 +1000 Michael Ellerman <mpe@ellerman.id.au> wrote:
> chengang@emindsoft.com.cn writes:
>
> > From: Chen Gang <chengang@emindsoft.com.cn>
> >
> > For pure bool function's return value, bool is a little better more or
> > less than int.
> >
> > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> > ---
> > arch/powerpc/include/asm/mman.h | 8 ++++----
> > include/linux/mman.h | 2 +-
> > 2 files changed, 5 insertions(+), 5 deletions(-)
>
> LGTM.
>
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
>
> Andrew do you want to take this or should I?
I grabbed it, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] include: mman: Use bool instead of int for the return value of arch_validate_prot
2016-07-26 0:08 ` Andrew Morton
@ 2016-07-26 1:15 ` Michael Ellerman
0 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2016-07-26 1:15 UTC (permalink / raw)
To: Andrew Morton
Cc: chengang, benh, paulus, dave.hansen, tglx, mingo, linuxppc-dev,
linux-kernel, Chen Gang
Andrew Morton <akpm@linux-foundation.org> writes:
> On Mon, 25 Jul 2016 15:10:06 +1000 Michael Ellerman <mpe@ellerman.id.au> wrote:
>> chengang@emindsoft.com.cn writes:
>> > From: Chen Gang <chengang@emindsoft.com.cn>
>> >
>> > For pure bool function's return value, bool is a little better more or
>> > less than int.
>> >
>> > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>>
>> LGTM.
>>
>> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
>>
>> Andrew do you want to take this or should I?
>
> I grabbed it, thanks.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-26 1:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-24 3:43 [PATCH v2] include: mman: Use bool instead of int for the return value of arch_validate_prot chengang
2016-07-25 5:10 ` Michael Ellerman
2016-07-26 0:08 ` Andrew Morton
2016-07-26 1:15 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.