From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relmlor2.renesas.com ([210.160.252.172]:14510 "EHLO relmlie1.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932251AbcGCX6m (ORCPT ); Sun, 3 Jul 2016 19:58:42 -0400 Message-ID: <8737nq1drw.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Mark Brown CC: Linux-ALSA , Liam Girdwood , Simon , Subject: Re: [PATCH 09/39 v2] ASoC: simple-card-utils: add asoc_simple_card_parse_clk() In-Reply-To: <20160701095521.GK6247@sirena.org.uk> References: <87fusysjam.wl%kuninori.morimoto.gx@renesas.com> <8737oysj1d.wl%kuninori.morimoto.gx@renesas.com> <20160629181843.GM6247@sirena.org.uk> <87bn2jbkck.wl%kuninori.morimoto.gx@renesas.com> <87a8i3bjp2.wl%kuninori.morimoto.gx@renesas.com> <20160701095521.GK6247@sirena.org.uk> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="US-ASCII" Date: Sun, 3 Jul 2016 23:58:37 +0000 Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Mark > > Oops, of_clk_get() doesn't have devm_of_clk_get() ? > > Perhaps add it? > > > (and no of_clk_put() ... ) > > I will keep above as-is in v3. We can fix it incrementally (?) > > You can just use regular clk_put() with of_clk_get(). Ohh.. OK, but can I do it in additional patch ? Because main purpose of this patch is cleanup by using util.c, not adding new feature. Maybe it can be 0001 add devm_of_clk_get() 0002 use devm_of_clk_get() on simple-card-utils.c From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Subject: Re: [PATCH 09/39 v2] ASoC: simple-card-utils: add asoc_simple_card_parse_clk() Date: Sun, 3 Jul 2016 23:58:37 +0000 Message-ID: <8737nq1drw.wl%kuninori.morimoto.gx@renesas.com> References: <87fusysjam.wl%kuninori.morimoto.gx@renesas.com> <8737oysj1d.wl%kuninori.morimoto.gx@renesas.com> <20160629181843.GM6247@sirena.org.uk> <87bn2jbkck.wl%kuninori.morimoto.gx@renesas.com> <87a8i3bjp2.wl%kuninori.morimoto.gx@renesas.com> <20160701095521.GK6247@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="US-ASCII" Return-path: In-Reply-To: <20160701095521.GK6247@sirena.org.uk> Sender: linux-renesas-soc-owner@vger.kernel.org To: Mark Brown Cc: Linux-ALSA , Liam Girdwood , Simon , linux-renesas-soc@vger.kernel.org List-Id: alsa-devel@alsa-project.org Hi Mark > > Oops, of_clk_get() doesn't have devm_of_clk_get() ? > > Perhaps add it? > > > (and no of_clk_put() ... ) > > I will keep above as-is in v3. We can fix it incrementally (?) > > You can just use regular clk_put() with of_clk_get(). Ohh.. OK, but can I do it in additional patch ? Because main purpose of this patch is cleanup by using util.c, not adding new feature. Maybe it can be 0001 add devm_of_clk_get() 0002 use devm_of_clk_get() on simple-card-utils.c