From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39781)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1aSqVL-0003t2-Sz
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 13:25:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1aSqVH-00043k-Jg
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 13:25:43 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35143)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1aSqVH-00043f-7R
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 13:25:39 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <1454945806-14090-1-git-send-email-eblake@redhat.com>
	<87bn7rrtib.fsf@blackfin.pond.sub.org>
	<CAFEAcA8QWDD_8KG_An-jDSg5q+pTBKG-eO=mSYmCRda05dhHBg@mail.gmail.com>
Date: Mon, 08 Feb 2016 19:25:36 +0100
In-Reply-To: <CAFEAcA8QWDD_8KG_An-jDSg5q+pTBKG-eO=mSYmCRda05dhHBg@mail.gmail.com>
	(Peter Maydell's message of "Mon, 8 Feb 2016 17:45:32 +0000")
Message-ID: <8737t3qctb.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] qapi: Clean up includes in generated files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Michael Roth <mdroth@linux.vnet.ibm.com>

Peter Maydell <peter.maydell@linaro.org> writes:

> On 8 February 2016 at 17:39, Markus Armbruster <armbru@redhat.com> wrote:
>> Eric Blake <eblake@redhat.com> writes:
>>
>>> As a followup to commit cbf2115, clean up the includes in files
>>> generated by QAPI so that osdep.h is included first in .c files,
>>> and headers which it implies are not included manually.  This
>>> patch is done manually, since Coccinelle (and therefore
>>> scripts/clean-includes) doesn't see into the generator scripts.
>>>
>>> Signed-off-by: Eric Blake <eblake@redhat.com>
>>
>>   CC    tests/check-qfloat.o
>> In file included from /home/armbru/work/qemu/include/qapi/qmp/qobject.h:=
37:0,
>>                  from /home/armbru/work/qemu/include/qapi/qmp/qfloat.h:1=
8,
>>                  from /home/armbru/work/qemu/tests/check-qfloat.c:15:
>> ./qapi-types.h:55:9: error: unknown type name =E2=80=98bool=E2=80=99
>>          bool value;
>>          ^
>>
>> Chicken and egg problem?  check-qfloat.c doesn't include osdep.h, yet...
>
> Easy enough to add it; I have 'run clean-includes on tests/' on
> my todo list, but it requires a little care because I think at
> least some .c files in tests/ do not have QEMU headers in their
> include path at all. This might just be tests/tcg/.

With "make check" fixed:
Reviewed-by: Markus Armbruster <armbru@redhat.com>

I'm happy to take it through my tree when it's ready (tell me then), but
it might be easier to take it along whatever fixes "make check".