From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753065AbbJFTSr (ORCPT ); Tue, 6 Oct 2015 15:18:47 -0400 Received: from smtp11.smtpout.orange.fr ([80.12.242.133]:57023 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752599AbbJFTSp (ORCPT ); Tue, 6 Oct 2015 15:18:45 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Tue, 06 Oct 2015 21:18:43 +0200 X-ME-IP: 90.38.170.78 From: Robert Jarzmik To: Philipp Zabel Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, LKML , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , linux-fbdev@vger.kernel.org Subject: Re: [PATCH v2] video: fbdev: add Marvell PXA framebuffer binding References: <1443954683-13126-1-git-send-email-robert.jarzmik@free.fr> X-URL: http://belgarath.falguerolles.org/ Date: Tue, 06 Oct 2015 21:13:25 +0200 In-Reply-To: (Philipp Zabel's message of "Tue, 6 Oct 2015 08:58:08 +0200") Message-ID: <8737xnbyju.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Philipp Zabel writes: > On Sun, Oct 4, 2015 at 12:31 PM, Robert Jarzmik wrote: >> + lcd-controller@40500000 { >> + compatible = "marvell,pxa2xx-lcdc"; >> + reg = <0x44000000 0x10000>; >> + interrupts = <17>; >> + clocks = <&clks CLK_LCD>; >> + interrupts = <23>; > > The interrupt line is duplicated in the example. Indeed, I'll fix that. > >> + status = "okay"; >> + >> + port { >> + lcdc_out: endpoint { >> + remote-endpoint = <&panel_in>; >> + bus-width = <16>; >> + }; >> + }; >> + }; >> + >> +PXA LCDC Display >> +---------------- >> +Required properties (as per of_videomode_helper): >> + - lcd-type: either "mono-stn", "mono-dstn", "color-stn", "color-dstn", >> + "color-tft", "smart-panel" > > Would it make sense to make this property optional and have the > default be "color-tft"? That is probably the most common one by far. Yes, sure, let's do it that way for v3. Cheers. -- Robert From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Date: Tue, 06 Oct 2015 19:13:25 +0000 Subject: Re: [PATCH v2] video: fbdev: add Marvell PXA framebuffer binding Message-Id: <8737xnbyju.fsf@belgarion.home> List-Id: References: <1443954683-13126-1-git-send-email-robert.jarzmik@free.fr> In-Reply-To: (Philipp Zabel's message of "Tue, 6 Oct 2015 08:58:08 +0200") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Philipp Zabel Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, LKML , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , linux-fbdev@vger.kernel.org Philipp Zabel writes: > On Sun, Oct 4, 2015 at 12:31 PM, Robert Jarzmik wrote: >> + lcd-controller@40500000 { >> + compatible = "marvell,pxa2xx-lcdc"; >> + reg = <0x44000000 0x10000>; >> + interrupts = <17>; >> + clocks = <&clks CLK_LCD>; >> + interrupts = <23>; > > The interrupt line is duplicated in the example. Indeed, I'll fix that. > >> + status = "okay"; >> + >> + port { >> + lcdc_out: endpoint { >> + remote-endpoint = <&panel_in>; >> + bus-width = <16>; >> + }; >> + }; >> + }; >> + >> +PXA LCDC Display >> +---------------- >> +Required properties (as per of_videomode_helper): >> + - lcd-type: either "mono-stn", "mono-dstn", "color-stn", "color-dstn", >> + "color-tft", "smart-panel" > > Would it make sense to make this property optional and have the > default be "color-tft"? That is probably the most common one by far. Yes, sure, let's do it that way for v3. Cheers. -- Robert