From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Subject: Re: [PATCH 6/6 v3] ASoC: rsnd: Add Volume Ramp support Date: Thu, 06 Nov 2014 16:11:12 -0800 (PST) Message-ID: <87389v98eo.wl%kuninori.morimoto.gx@gmail.com> References: <87egtp2g05.wl%kuninori.morimoto.gx@gmail.com> <87egti46j7.wl%kuninori.morimoto.gx@gmail.com> <8761eu46cz.wl%kuninori.morimoto.gx@gmail.com> <20141106165829.GQ8509@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pd0-f172.google.com (mail-pd0-f172.google.com [209.85.192.172]) by alsa0.perex.cz (Postfix) with ESMTP id 52B642654CE for ; Fri, 7 Nov 2014 01:11:15 +0100 (CET) Received: by mail-pd0-f172.google.com with SMTP id r10so2142601pdi.17 for ; Thu, 06 Nov 2014 16:11:14 -0800 (PST) In-Reply-To: <20141106165829.GQ8509@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Linux-ALSA , Simon , Liam Girdwood , Kuninori Morimoto List-Id: alsa-devel@alsa-project.org Hi Mark Thank you for your review > > amixer set "DVC Out" 100% // = Normal Volume > > amixer set "DVC Out Ramp Up Rate" "0.125 dB/64 steps" > > amixer set "DVC Out Ramp Down Rate" "0.125 dB/512 steps" > > amixer set "DVC Out Ramp" 0% // Mute = Normal Volume x 0% > > amixer set "DVC Out Ramp" on // Volume Ramp ON > > aplay xxx.wav & > > amixer set "DVC Out Ramp" 100% // Mute to Normal Volume x 100% > > amixer set "DVC Out Ramp" 0% // Normal Volume x 100% to Mute > > Correct me if I'm wrong but I think what's confusing me here is that > what I'd expect to happen is that setting the ramp rate would cause any > volume change done by the user to ramp to the target volume (or mute) > but it looks like what's actually happening is that the ramp control is > providing an additional layer of volume control on top of the normal > volume control. Sorry for my poor explanation. Yes, you are correct. Volume Ramp chenges [ramp layer] (0% - 100%) [ramp layer] is always 100% if you don't use Volume Ramp. [Normal Volume] x [ramp layer] = output Please let me better/understandable naming.