From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] exfat: bump to version 1.1.0
Date: Thu, 11 Sep 2014 22:43:05 +0200 [thread overview]
Message-ID: <8738bxevmu.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1410376050-21735-1-git-send-email-gustavo@zacarias.com.ar> (Gustavo Zacarias's message of "Wed, 10 Sep 2014 16:07:29 -0300")
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:
> Use gentoo distfiles since the download infra can't handle google docs
> URLs.
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
> package/exfat/exfat.mk | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
> diff --git a/package/exfat/exfat.mk b/package/exfat/exfat.mk
> index 3c0dece..279c6a0 100644
> --- a/package/exfat/exfat.mk
> +++ b/package/exfat/exfat.mk
> @@ -4,8 +4,8 @@
> #
> ################################################################################
> -EXFAT_VERSION = 1.0.1
> -EXFAT_SITE = http://exfat.googlecode.com/files
> +EXFAT_VERSION = 1.1.0
> +EXFAT_SITE = http://distfiles.gentoo.org/distfiles
> EXFAT_SOURCE = fuse-exfat-$(EXFAT_VERSION).tar.gz
> EXFAT_DEPENDENCIES = host-scons libfuse
> EXFAT_LICENSE = GPLv3+
> @@ -13,12 +13,12 @@ EXFAT_LICENSE_FILES = COPYING
> define EXFAT_BUILD_CMDS
> (cd $(@D); \
> - $(TARGET_CONFIGURE_OPTS) $(SCONS))
> + $(TARGET_CONFIGURE_OPTS) CCFLAGS="-std=c99" $(SCONS))
Shouldn't this be CCFLAGS="$(TARGET_CFLAGS) -std=c99"?
From a quick test it seems like it should:
>>> exfat 1.1.0 Building
(cd /home/peko/source/buildroot/output/build/exfat-1.1.0; <snip>
CPPFLAGS="-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64"
CFLAGS="-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -pipe -Os "
<snip>
/home/peko/source/buildroot/output/host/usr/bin/arm-none-linux-gnueabi-gcc
-o fuse/main.o -c -std=c99 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-D_FILE_OFFSET_BITS=64 -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -Ilibexfat
fuse/main.c
It looks like it only uses CPPFLAGS and CCFLAGS.
Committed with that fixed, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2014-09-11 20:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 19:07 [Buildroot] [PATCH 1/2] exfat: bump to version 1.1.0 Gustavo Zacarias
2014-09-10 19:07 ` [Buildroot] [PATCH 2/2] exfat-utils: " Gustavo Zacarias
2014-09-11 20:44 ` Peter Korsgaard
2014-09-11 20:43 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738bxevmu.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.