From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth01.qualcomm.com ([65.197.215.72]:16862 "EHLO sabertooth01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750848AbaDKFlD (ORCPT ); Fri, 11 Apr 2014 01:41:03 -0400 From: Kalle Valo To: Michal Kazior CC: , , Subject: Re: [PATCH] ath10k: double check bmi xfer pointers References: <53461A8A.4030209@candelatech.com> <1397124355-6321-1-git-send-email-michal.kazior@tieto.com> Date: Fri, 11 Apr 2014 08:40:56 +0300 In-Reply-To: <1397124355-6321-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Thu, 10 Apr 2014 12:05:55 +0200") Message-ID: <8738hkh193.fsf@kamboji.qca.qualcomm.com> (sfid-20140411_074140_482821_68C9DF11) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Michal Kazior writes: > If for some reason copy engine ring buffer became > corrupt ath10k could crash the machine due to > invalid pointer dereference. It's very unlikely > but devices can never be fully trusted so verify > if the bmi xfer pointer read back from copy engine > matches the original pointer. The big question is why does this happen? Does this happen only with Ben's firmware or is it a more generic problem? -- Kalle Valo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WYUDN-0008CP-4n for ath10k@lists.infradead.org; Fri, 11 Apr 2014 05:41:25 +0000 From: Kalle Valo Subject: Re: [PATCH] ath10k: double check bmi xfer pointers References: <53461A8A.4030209@candelatech.com> <1397124355-6321-1-git-send-email-michal.kazior@tieto.com> Date: Fri, 11 Apr 2014 08:40:56 +0300 In-Reply-To: <1397124355-6321-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Thu, 10 Apr 2014 12:05:55 +0200") Message-ID: <8738hkh193.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Michal Kazior Cc: greearb@candelatech.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Michal Kazior writes: > If for some reason copy engine ring buffer became > corrupt ath10k could crash the machine due to > invalid pointer dereference. It's very unlikely > but devices can never be fully trusted so verify > if the bmi xfer pointer read back from copy engine > matches the original pointer. The big question is why does this happen? Does this happen only with Ben's firmware or is it a more generic problem? -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k