From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754476Ab3HPWSx (ORCPT ); Fri, 16 Aug 2013 18:18:53 -0400 Received: from mail-pd0-f178.google.com ([209.85.192.178]:58702 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199Ab3HPWSv (ORCPT ); Fri, 16 Aug 2013 18:18:51 -0400 From: Kevin Hilman To: Johannes Weiner Cc: Mel Gorman , Andrew Morton , Rik van Riel , Andrea Arcangeli , Zlatko Calusic , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, sfr@canb.auug.org.au, linux-arm-kernel@lists.infradead.org, Olof Johansson , Stephen Warren Subject: Re: [patch v2 3/3] mm: page_alloc: fair zone allocator policy References: <1375457846-21521-1-git-send-email-hannes@cmpxchg.org> <1375457846-21521-4-git-send-email-hannes@cmpxchg.org> <20130807145828.GQ2296@suse.de> <20130807153743.GH715@cmpxchg.org> <20130808041623.GL1845@cmpxchg.org> <87haepblo2.fsf@kernel.org> <20130816201814.GA26409@cmpxchg.org> Date: Fri, 16 Aug 2013 14:52:11 -0700 In-Reply-To: <20130816201814.GA26409@cmpxchg.org> (Johannes Weiner's message of "Fri, 16 Aug 2013 16:18:14 -0400") Message-ID: <8738q9b8xg.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Johannes Weiner writes: > Hi Kevin, > > On Fri, Aug 16, 2013 at 10:17:01AM -0700, Kevin Hilman wrote: >> Johannes Weiner writes: >> > On Wed, Aug 07, 2013 at 11:37:43AM -0400, Johannes Weiner wrote: >> > Subject: [patch] mm: page_alloc: use vmstats for fair zone allocation batching >> > >> > Avoid dirtying the same cache line with every single page allocation >> > by making the fair per-zone allocation batch a vmstat item, which will >> > turn it into batched percpu counters on SMP. >> > >> > Signed-off-by: Johannes Weiner >> >> I bisected several boot failures on various ARM platform in >> next-20130816 down to this patch (commit 67131f9837 in linux-next.) >> >> Simply reverting it got things booting again on top of -next. Example >> boot crash below. > > Thanks for the bisect and report! You're welcome. Thanks for the quick fix! > I deref the percpu pointers before initializing them properly. It > didn't trigger on x86 because the percpu offset added to the pointer > is big enough so that it does not fall into PFN 0, but it probably > ended up corrupting something... > > Could you try this patch on top of linux-next instead of the revert? Yup, that change fixes it. Tested-by: Kevin Hilman Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx112.postini.com [74.125.245.112]) by kanga.kvack.org (Postfix) with SMTP id 24D676B0032 for ; Fri, 16 Aug 2013 17:52:16 -0400 (EDT) Received: by mail-pb0-f49.google.com with SMTP id xb4so2469280pbc.36 for ; Fri, 16 Aug 2013 14:52:15 -0700 (PDT) From: Kevin Hilman Subject: Re: [patch v2 3/3] mm: page_alloc: fair zone allocator policy References: <1375457846-21521-1-git-send-email-hannes@cmpxchg.org> <1375457846-21521-4-git-send-email-hannes@cmpxchg.org> <20130807145828.GQ2296@suse.de> <20130807153743.GH715@cmpxchg.org> <20130808041623.GL1845@cmpxchg.org> <87haepblo2.fsf@kernel.org> <20130816201814.GA26409@cmpxchg.org> Date: Fri, 16 Aug 2013 14:52:11 -0700 In-Reply-To: <20130816201814.GA26409@cmpxchg.org> (Johannes Weiner's message of "Fri, 16 Aug 2013 16:18:14 -0400") Message-ID: <8738q9b8xg.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner Cc: Mel Gorman , Andrew Morton , Rik van Riel , Andrea Arcangeli , Zlatko Calusic , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, sfr@canb.auug.org.au, linux-arm-kernel@lists.infradead.org, Olof Johansson , Stephen Warren Johannes Weiner writes: > Hi Kevin, > > On Fri, Aug 16, 2013 at 10:17:01AM -0700, Kevin Hilman wrote: >> Johannes Weiner writes: >> > On Wed, Aug 07, 2013 at 11:37:43AM -0400, Johannes Weiner wrote: >> > Subject: [patch] mm: page_alloc: use vmstats for fair zone allocation batching >> > >> > Avoid dirtying the same cache line with every single page allocation >> > by making the fair per-zone allocation batch a vmstat item, which will >> > turn it into batched percpu counters on SMP. >> > >> > Signed-off-by: Johannes Weiner >> >> I bisected several boot failures on various ARM platform in >> next-20130816 down to this patch (commit 67131f9837 in linux-next.) >> >> Simply reverting it got things booting again on top of -next. Example >> boot crash below. > > Thanks for the bisect and report! You're welcome. Thanks for the quick fix! > I deref the percpu pointers before initializing them properly. It > didn't trigger on x86 because the percpu offset added to the pointer > is big enough so that it does not fall into PFN 0, but it probably > ended up corrupting something... > > Could you try this patch on top of linux-next instead of the revert? Yup, that change fixes it. Tested-by: Kevin Hilman Kevin -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@linaro.org (Kevin Hilman) Date: Fri, 16 Aug 2013 14:52:11 -0700 Subject: [patch v2 3/3] mm: page_alloc: fair zone allocator policy In-Reply-To: <20130816201814.GA26409@cmpxchg.org> (Johannes Weiner's message of "Fri, 16 Aug 2013 16:18:14 -0400") References: <1375457846-21521-1-git-send-email-hannes@cmpxchg.org> <1375457846-21521-4-git-send-email-hannes@cmpxchg.org> <20130807145828.GQ2296@suse.de> <20130807153743.GH715@cmpxchg.org> <20130808041623.GL1845@cmpxchg.org> <87haepblo2.fsf@kernel.org> <20130816201814.GA26409@cmpxchg.org> Message-ID: <8738q9b8xg.fsf@kernel.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Johannes Weiner writes: > Hi Kevin, > > On Fri, Aug 16, 2013 at 10:17:01AM -0700, Kevin Hilman wrote: >> Johannes Weiner writes: >> > On Wed, Aug 07, 2013 at 11:37:43AM -0400, Johannes Weiner wrote: >> > Subject: [patch] mm: page_alloc: use vmstats for fair zone allocation batching >> > >> > Avoid dirtying the same cache line with every single page allocation >> > by making the fair per-zone allocation batch a vmstat item, which will >> > turn it into batched percpu counters on SMP. >> > >> > Signed-off-by: Johannes Weiner >> >> I bisected several boot failures on various ARM platform in >> next-20130816 down to this patch (commit 67131f9837 in linux-next.) >> >> Simply reverting it got things booting again on top of -next. Example >> boot crash below. > > Thanks for the bisect and report! You're welcome. Thanks for the quick fix! > I deref the percpu pointers before initializing them properly. It > didn't trigger on x86 because the percpu offset added to the pointer > is big enough so that it does not fall into PFN 0, but it probably > ended up corrupting something... > > Could you try this patch on top of linux-next instead of the revert? Yup, that change fixes it. Tested-by: Kevin Hilman Kevin