All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Jens Axboe <axboe@kernel.dk>
Cc: Aurelien Jarno <aurelien@aurel32.net>,
	kvm@vger.kernel.org, Ian Molton <ian.molton@collabora.co.uk>,
	Matt Mackall <mpm@selenic.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Ben Hutchings <ben@decadent.org.uk>
Subject: Re: virtio-rng only returns zeros with CONFIG_HW_RANDOM=m
Date: Thu, 28 Feb 2013 13:30:21 +1030	[thread overview]
Message-ID: <8738whdtx6.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20130227132213.GF4615@kernel.dk>

Jens Axboe <axboe@kernel.dk> writes:
> On Wed, Feb 27 2013, Rusty Russell wrote:
>> Subject: scatterlist: sg_set_buf() argument must be in linear mapping.
>> 
>> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>> 
>> diff --git a/include/linux/scatterlist.h b/include/linux/scatterlist.h
>> index 4bd6c06..9365375 100644
>> --- a/include/linux/scatterlist.h
>> +++ b/include/linux/scatterlist.h
>> @@ -111,6 +111,9 @@ static inline struct page *sg_page(struct scatterlist *sg)
>>  static inline void sg_set_buf(struct scatterlist *sg, const void *buf,
>>  			      unsigned int buflen)
>>  {
>> +#ifdef CONFIG_DEBUG_SG
>> +	BUG_ON(!virt_addr_valid(buf));
>> +#endif
>>  	sg_set_page(sg, virt_to_page(buf), buflen, offset_in_page(buf));
>>  }
>
> Looks good to me, in lieu of being able to return an error. Want me to
> queue it up?

Please... it'll catch me the next time I make the same mistake :)

(Though the static-definitions-in-modules-on-most-archs is a pretty
nasty corner case).

Thanks,
Rusty.

  reply	other threads:[~2013-02-28  3:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-24 23:11 virtio-rng only returns zeros with CONFIG_HW_RANDOM=m Aurelien Jarno
2013-02-27  0:13 ` Rusty Russell
2013-02-27  3:40   ` Ben Hutchings
2013-02-27 10:33   ` Aurelien Jarno
2013-02-27 13:22   ` Jens Axboe
2013-02-28  3:00     ` Rusty Russell [this message]
2013-05-30  1:07     ` Rusty Russell
2013-05-30  7:18       ` Jens Axboe
2013-02-27  1:26 ` Rusty Russell
2013-02-27 16:36   ` Aurelien Jarno
2013-02-28  3:04     ` Rusty Russell
2013-03-10  8:26   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738whdtx6.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=aurelien@aurel32.net \
    --cc=axboe@kernel.dk \
    --cc=ben@decadent.org.uk \
    --cc=herbert@gondor.apana.org.au \
    --cc=ian.molton@collabora.co.uk \
    --cc=kvm@vger.kernel.org \
    --cc=mpm@selenic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.