From: Petr Rockai <prockai@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Avoid recursive calls from dmeventd to itself
Date: Thu, 01 Sep 2011 03:08:03 +0200 [thread overview]
Message-ID: <8739gh3w98.fsf@aldalome.int.mornfall.net.> (raw)
Hi,
the attached patch keeps the LVM-based dmeventd plugins from trying to
manipulate the dmeventd monitoring state of the logical volumes they are
currently acting on.
Until now, every time a logical volume has been changed by a dmeventd
plugin, this plugin would have called back to dmeventd through the
external FIFO mechanism. I am fairly sure this is superfluous,
inefficient and possibly even dangerous.
It is probably related to RHBZ 707056 and I wouldn't be surprised if
this sometimes caused mirror repair issues. With the patch, the
incidence of "No longer monitoring..." messages while repairing mirrors
drops dramatically.
Yours,
Petr
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dmeventd_norecurse.diff
Type: text/x-diff
Size: 1806 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20110901/b65fdb7c/attachment.bin>
-------------- next part --------------
--
id' Ash = Ash; id' Dust = Dust; id' _ = undefined
next reply other threads:[~2011-09-01 1:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 1:08 Petr Rockai [this message]
2011-09-01 19:42 ` [PATCH] Avoid recursive calls from dmeventd to itself Alasdair G Kergon
2011-09-02 12:50 ` Petr Rockai
2011-10-10 14:33 ` Petr Rockai
2011-10-18 12:56 ` Milan Broz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8739gh3w98.fsf@aldalome.int.mornfall.net. \
--to=prockai@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.