From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 846D3C43215 for ; Mon, 25 Nov 2019 12:28:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 517592082F for ; Mon, 25 Nov 2019 12:28:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QgY4gGQ6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 517592082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZDTH-0006e4-19 for qemu-devel@archiver.kernel.org; Mon, 25 Nov 2019 07:28:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59020) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZDMp-0007OF-NB for qemu-devel@nongnu.org; Mon, 25 Nov 2019 07:21:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZDAR-0002sU-J1 for qemu-devel@nongnu.org; Mon, 25 Nov 2019 07:08:36 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:40466 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iZDAR-0002rq-FQ for qemu-devel@nongnu.org; Mon, 25 Nov 2019 07:08:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574683712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hgHdzUT3n6+d6Y5DbWcm323dAP0D0sC1MeZofJg/mrg=; b=QgY4gGQ6MLANpFIZ5M2c9bapGqkyevEcf78Q1jvsbGZwehBLR/kjVCC56LrR5JtuS1+fQm /EvuqLon7lu1++0WMEkqZjoQuECy0Wh3e0VjrgeIzR3zptHIaD7BpoN6Ots+grCKx84N63 WamJINJvcUYudf3MzHxN5rWd6vU91DE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-326-_-XC2CJGNWm_3cG_bJf4GQ-1; Mon, 25 Nov 2019 07:08:26 -0500 X-MC-Unique: _-XC2CJGNWm_3cG_bJf4GQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BB752911EB; Mon, 25 Nov 2019 12:08:25 +0000 (UTC) Received: from dresden.str.redhat.com (unknown [10.40.205.102]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CC04A19C6A; Mon, 25 Nov 2019 12:08:18 +0000 (UTC) Subject: Re: [PATCH v3 4/8] block: truncate: Don't make backing file data visible To: Kevin Wolf , qemu-block@nongnu.org References: <20191122160511.8377-1-kwolf@redhat.com> <20191122160511.8377-5-kwolf@redhat.com> From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <873a49c5-95e3-eb5e-41ef-2f34b0a31ef7@redhat.com> Date: Mon, 25 Nov 2019 13:08:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191122160511.8377-5-kwolf@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2Ov30QocAJOBnOS2AOa9t5NcmU1bgdjw9" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vsementsov@virtuozzo.com, qemu-devel@nongnu.org, stefanha@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2Ov30QocAJOBnOS2AOa9t5NcmU1bgdjw9 Content-Type: multipart/mixed; boundary="pVy3a9iEC0vaalcLGQr0hBjeYZLZHhYAM" --pVy3a9iEC0vaalcLGQr0hBjeYZLZHhYAM Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 22.11.19 17:05, Kevin Wolf wrote: > When extending the size of an image that has a backing file larger than > its old size, make sure that the backing file data doesn't become > visible in the guest, but the added area is properly zeroed out. >=20 > Consider the following scenario where the overlay is shorter than its > backing file: >=20 > base.qcow2: AAAAAAAA > overlay.qcow2: BBBB >=20 > When resizing (extending) overlay.qcow2, the new blocks should not stay > unallocated and make the additional As from base.qcow2 visible like > before this patch, but zeros should be read. >=20 > A similar case happens with the various variants of a commit job when an > intermediate file is short (- for unallocated): >=20 > base.qcow2: A-A-AAAA > mid.qcow2: BB-B > top.qcow2: C--C--C- >=20 > After commit top.qcow2 to mid.qcow2, the following happens: >=20 > mid.qcow2: CB-C00C0 (correct result) > mid.qcow2: CB-C--C- (before this fix) >=20 > Without the fix, blocks that previously read as zeros on top.qcow2 > suddenly turn into A. >=20 > Signed-off-by: Kevin Wolf > --- > block/io.c | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) Reviewed-by: Max Reitz --pVy3a9iEC0vaalcLGQr0hBjeYZLZHhYAM-- --2Ov30QocAJOBnOS2AOa9t5NcmU1bgdjw9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl3bxDEACgkQ9AfbAGHV z0CAZQgAi3WFUvh9xnsQjoC8GJ1Mr6y0SVmxp4Qlxou15hbBeHmBdPw7b4tv52CJ en1EvrGLs4p/cIVEt8XD9xEbXiNYrBstEtXkoWvsXitSvc2eDOmxSLc2g3k5oGXx oaU+L4hJDXGXhAJZ4AwAJdTwNYJq5/lKYfSumyAj6rK4QaDKKrvo2IuNrpBkX3Cm 2KBT0y5wZVBoiAA7f6svQXWjQ0rWYF/euJotSkc+yKbCbzrHAyg1y8IsyGL6pdY8 DRiroPL8CxIbkDUA/q7VYIMK+pPcW0YZK3eDc19ZihWLhWnd85f/8cm5/6exVPdO kKYieAH/SyDnB8Mqsxo1dULA8xSNIQ== =09x0 -----END PGP SIGNATURE----- --2Ov30QocAJOBnOS2AOa9t5NcmU1bgdjw9--