From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lokesh Vutla Date: Fri, 24 Jul 2020 18:40:18 +0530 Subject: [PATCH 07/18] arm: mach-k3: j721e: Add detection for j721e In-Reply-To: <0ddf0d4a-e177-9982-bb94-91bea8e7ed1d@ti.com> References: <20200723084718.19430-1-lokeshvutla@ti.com> <20200723084718.19430-8-lokeshvutla@ti.com> <0ddf0d4a-e177-9982-bb94-91bea8e7ed1d@ti.com> Message-ID: <87432433-7717-74cf-5923-30d88eb975ad@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 24/07/20 5:55 pm, Grygorii Strashko wrote: > > > On 23/07/2020 11:47, Lokesh Vutla wrote: >> Add an api soc_is_j721e(), and use it to enable certain functionality >> that is available only on j721e. >> >> Signed-off-by: Lokesh Vutla >> Signed-off-by: Suman Anna >> --- >> ? arch/arm/mach-k3/common.c???????????????? | 10 ++++++++++ >> ? arch/arm/mach-k3/include/mach/sys_proto.h |? 2 ++ >> ? arch/arm/mach-k3/j721e_init.c???????????? |? 3 +++ >> ? 3 files changed, 15 insertions(+) >> >> diff --git a/arch/arm/mach-k3/common.c b/arch/arm/mach-k3/common.c >> index eb72451d06..aec6c600b9 100644 >> --- a/arch/arm/mach-k3/common.c >> +++ b/arch/arm/mach-k3/common.c >> @@ -355,6 +355,16 @@ int print_cpuinfo(void) >> ? } >> ? #endif >> ? +bool soc_is_j721e(void) >> +{ >> +??? u32 soc; >> + >> +??? soc = (readl(CTRLMMR_WKUP_JTAG_ID) & >> +??????? JTAG_ID_PARTNO_MASK) >> JTAG_ID_PARTNO_SHIFT; >> + >> +??? return soc == J721E; >> +} > > Shouldn't it be done using UCLASS_SOC introduce by Dave Gerlach > > https://patchwork.ozlabs.org/project/uboot/cover/20200716044004.6014-1-d-gerlach at ti.com/ SoC differentiation is needed before DT is available. So I had to use these apis. Thanks and regards, Lokesh