From: Marek Vasut <marex@denx.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Mark Brown <broonie@kernel.org>, dri-devel@lists.freedesktop.org
Subject: Re: [RFC][PATCH] regulator: rpi-panel: Add regulator/backlight driver for RPi panel
Date: Thu, 30 Jul 2020 18:28:07 +0200 [thread overview]
Message-ID: <87447ebd-2838-c6bb-1dd4-28104f09dbb9@denx.de> (raw)
In-Reply-To: <20200730155944.GA1477410@ravnborg.org>
On 7/30/20 5:59 PM, Sam Ravnborg wrote:
> Hi Marek
Hi,
> On Wed, Jul 29, 2020 at 11:46:45PM +0200, Marek Vasut wrote:
>> This regulator/backlight driver handles the ATTINY88 present on the
>> RPi 7" touchscreen panel and exposes the power/backlight interfaces.
[...]
> It looks strange that the regulator and the backligth are defined in the
> same module like this.
It's one chip, attiny with custom firmware, what do you want me to do
about it ? I can over-complicate this and split it into multiple
drivers, but I don't think it's worth the complexity, considering that
this is likely a one-off device which will never be re-used elsewhere,
except on this one particular display module for RPi.
> The usual approach is to have an independent regulator and an
> independent backlight. Each are represented by their own node in the DT.
>
> Also the compatible "raspberrypi,7inch-touchscreen-panel-regulator",
> is unknown. We need a binding for the compatible.
I submitted the patch as RFC to get feedback on how to handle this, so
yes, there are no DT bindings, that's on the todo.
> For backlight drivers, and modules that includes backlight support it
> would be good to include the backlight gang in cc:
> Jingoo, Lee, Daniel.
[...]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-07-31 7:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 21:46 [RFC][PATCH] regulator: rpi-panel: Add regulator/backlight driver for RPi panel Marek Vasut
2020-07-30 15:59 ` Sam Ravnborg
2020-07-30 16:28 ` Marek Vasut [this message]
2020-07-30 19:13 ` Mark Brown
2020-07-30 19:37 ` Marek Vasut
2020-08-01 1:16 ` Mark Brown
2020-08-03 7:21 ` Marek Vasut
2020-08-03 19:48 ` Mark Brown
2020-08-03 22:29 ` Marek Vasut
2020-08-04 14:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87447ebd-2838-c6bb-1dd4-28104f09dbb9@denx.de \
--to=marex@denx.de \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.