From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 058ADC433EF for ; Mon, 11 Apr 2022 22:25:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234159AbiDKW10 (ORCPT ); Mon, 11 Apr 2022 18:27:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbiDKW1Z (ORCPT ); Mon, 11 Apr 2022 18:27:25 -0400 Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 340E2140F1 for ; Mon, 11 Apr 2022 15:25:09 -0700 (PDT) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id EEACF83ABE; Tue, 12 Apr 2022 00:25:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1649715905; bh=yW5zcwopKy57mZCpilVjn7JXDbDMso804yPPSKcRi0U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=0XMoCsUKhjFfDcCBDB2MMWWDrwIvVUh8SpnDtteGE2cs02qVxZP0M1A8AFU44PANl HAOqlmaVeKbTPnJhkvSR8QsoHpYuBljX4n3sQ6ykImfWdFGakZyMQIZ8AkqGp0XEey PeMa86Kr1AhvxK6YU8QQ07Q9f4E4UDONTkVrKd0e5H8J8QhedF2OjmNRROn1DqK7wW oNeoOSb0mO8IajWMf1hL5BXAtJ1jzuyN5D78agC6j2p1Dhuaq1qP3xItywhPZ2wxBe rgCH67PFWXS96EG1BXRBKj80BG9ApmpGjrcLrrBHn38KmK0NnJHbRi+/ubmVEeVoBb ARgvTzLQspKaA== Message-ID: <87480099-7962-42a2-5e3b-0ac8f06a9aca@denx.de> Date: Tue, 12 Apr 2022 00:25:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v4 02/11] soc: imx: add i.MX8MP HSIO blk-ctrl Content-Language: en-US To: Lucas Stach , Shawn Guo , Rob Herring , Krzysztof Kozlowski Cc: Fabio Estevam , Pengutronix Kernel Team , NXP Linux Team , Laurent Pinchart , Paul Elder , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220406153402.1265474-1-l.stach@pengutronix.de> <20220406153402.1265474-3-l.stach@pengutronix.de> <25744e36-63ee-7669-067a-a671a5f461d6@denx.de> From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 4/11/22 18:46, Lucas Stach wrote: > Am Montag, dem 11.04.2022 um 00:11 +0200 schrieb Marek Vasut: >> On 4/7/22 11:12, Lucas Stach wrote: >>> Am Donnerstag, dem 07.04.2022 um 01:43 +0200 schrieb Marek Vasut: >>>> On 4/6/22 17:33, Lucas Stach wrote: >>>> >>>> [...] >>>> >>>>> +static const struct imx8mp_blk_ctrl_data imx8mp_hsio_blk_ctl_dev_data = { >>>>> + .max_reg = 0x24, >>>> >>>> Doesn't the HSIO_BLK_CTL go up to 0x10c ? >>> >>> Technically yes, but there is already a driver for the USB glue >>> (fsl,imx8mp-dwc3) that occupies the USB registers at and above 0x100. >> >> Shouldn't that imx8mp-dwc3 glue code be switched to syscon and access >> the registers through this driver then ? > > I don't see why this would be needed. Registers up to 0x24 are a mixed > bag of blk-ctrls, but the registers above 0x100 are only USB wakeup > related, I don't see the blk-ctrl ever wanting to touch them. > > I think the current split is fine. Just because the RM lumps those > register regions together into the HSIO blk-ctrl description doesn't > mean we need to cover them all in a single syscon. I guess we can also always fix this up later, OK. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CDE5C433EF for ; Mon, 11 Apr 2022 22:26:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kaubJmjerRy/+sI0mXnhT3LYAkzuWXsuqkKcsDzrPPE=; b=PbnC1CGdFMwEo7 m4t50+pl75xmUNneeRTL2oRSPw/a3R+Yl7h8mHHrXXSUkalxKMeUZfLOVOoCb9CRo265VsyZTMu5P 6VSRGIktnT71NiBH9xM3Sy/yjhsmjpForZRusC6+1oXKiIgDW5hp2IdbWo9zRJeTjBqY5YhP/TTP+ G9yGu1T5eoEJYahBrUQWsWUndedKxY/EQyNj5sVvwTxoQ6RzVCBRAb8Njy0Q4bfA2Iwwy3P5VHac6 BRRDE9b7VRd23p2aOC0c19kbKulVtnVAkm0y/sb0F/d+Tf6oOEr4JYucIBsTWedZtxet3kWx7+ZkW o8SmV2Y7ss2ZB7xHptfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ne2TA-00AgU1-4e; Mon, 11 Apr 2022 22:25:12 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ne2T7-00AgSv-DD for linux-arm-kernel@lists.infradead.org; Mon, 11 Apr 2022 22:25:10 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id EEACF83ABE; Tue, 12 Apr 2022 00:25:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1649715905; bh=yW5zcwopKy57mZCpilVjn7JXDbDMso804yPPSKcRi0U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=0XMoCsUKhjFfDcCBDB2MMWWDrwIvVUh8SpnDtteGE2cs02qVxZP0M1A8AFU44PANl HAOqlmaVeKbTPnJhkvSR8QsoHpYuBljX4n3sQ6ykImfWdFGakZyMQIZ8AkqGp0XEey PeMa86Kr1AhvxK6YU8QQ07Q9f4E4UDONTkVrKd0e5H8J8QhedF2OjmNRROn1DqK7wW oNeoOSb0mO8IajWMf1hL5BXAtJ1jzuyN5D78agC6j2p1Dhuaq1qP3xItywhPZ2wxBe rgCH67PFWXS96EG1BXRBKj80BG9ApmpGjrcLrrBHn38KmK0NnJHbRi+/ubmVEeVoBb ARgvTzLQspKaA== Message-ID: <87480099-7962-42a2-5e3b-0ac8f06a9aca@denx.de> Date: Tue, 12 Apr 2022 00:25:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v4 02/11] soc: imx: add i.MX8MP HSIO blk-ctrl Content-Language: en-US To: Lucas Stach , Shawn Guo , Rob Herring , Krzysztof Kozlowski Cc: Fabio Estevam , Pengutronix Kernel Team , NXP Linux Team , Laurent Pinchart , Paul Elder , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220406153402.1265474-1-l.stach@pengutronix.de> <20220406153402.1265474-3-l.stach@pengutronix.de> <25744e36-63ee-7669-067a-a671a5f461d6@denx.de> From: Marek Vasut In-Reply-To: X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220411_152509_724381_2F1B189C X-CRM114-Status: GOOD ( 14.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/11/22 18:46, Lucas Stach wrote: > Am Montag, dem 11.04.2022 um 00:11 +0200 schrieb Marek Vasut: >> On 4/7/22 11:12, Lucas Stach wrote: >>> Am Donnerstag, dem 07.04.2022 um 01:43 +0200 schrieb Marek Vasut: >>>> On 4/6/22 17:33, Lucas Stach wrote: >>>> >>>> [...] >>>> >>>>> +static const struct imx8mp_blk_ctrl_data imx8mp_hsio_blk_ctl_dev_data = { >>>>> + .max_reg = 0x24, >>>> >>>> Doesn't the HSIO_BLK_CTL go up to 0x10c ? >>> >>> Technically yes, but there is already a driver for the USB glue >>> (fsl,imx8mp-dwc3) that occupies the USB registers at and above 0x100. >> >> Shouldn't that imx8mp-dwc3 glue code be switched to syscon and access >> the registers through this driver then ? > > I don't see why this would be needed. Registers up to 0x24 are a mixed > bag of blk-ctrls, but the registers above 0x100 are only USB wakeup > related, I don't see the blk-ctrl ever wanting to touch them. > > I think the current split is fine. Just because the RM lumps those > register regions together into the HSIO blk-ctrl description doesn't > mean we need to cover them all in a single syscon. I guess we can also always fix this up later, OK. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel