From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AE82C46467 for ; Mon, 28 Nov 2022 22:11:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234436AbiK1WLK (ORCPT ); Mon, 28 Nov 2022 17:11:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234148AbiK1WLK (ORCPT ); Mon, 28 Nov 2022 17:11:10 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9E8724BDE for ; Mon, 28 Nov 2022 14:10:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669673415; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vJAfrSiLBZ1GH3+ALah4IS7MdEjQe3AC2nBRfXse76c=; b=BZggZHzwZz0K8ECXZBTQ/CJ0/lLpqdBU4RjEmcp6dvXaXp5iCJ556J8KzBPBr5PocbmaB3 3lLxf1IKLXO8Ox2BZcRoJsvKOG8Txm6FlmbMIdtlSK5MXEoPJVA15HOlU8ZKXw7jz1WCe4 fbvOI/8V3RGjHTnn7gW8ni2Y0JAq8HQ= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-581-yRXYLuY4M8qw8G2CgOhs0w-1; Mon, 28 Nov 2022 17:10:13 -0500 X-MC-Unique: yRXYLuY4M8qw8G2CgOhs0w-1 Received: by mail-ej1-f72.google.com with SMTP id hb35-20020a170907162300b007ae6746f240so5097967ejc.12 for ; Mon, 28 Nov 2022 14:10:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vJAfrSiLBZ1GH3+ALah4IS7MdEjQe3AC2nBRfXse76c=; b=yTsIRYNPXjNKY/aIzLD7mMk2mLg+WZ9ovri/lMykHI1PjEWTTKjRBiN0v8kTU42lTN y6yXdd0Z6U/wfilzjdPZwSkjPbjjfiGiZJVRz6KHBUHIDZ7tj/ol/zQ7TDxCJvqesDQO mJYFaHjKTdawg/peWD4Y+lwJpaALXB03IG12u9qxbKpVhIeD3BPN7USOpirucj4kh2Hj tGGMu6oagKKFq14kkTcNO/aZnC+tSEuz/8bvJiFaxLxlmrVzff2BAwElt0vuGye0vMLm Xf/q52C0zB5iQ2UeLrHuJcYxBhUr2OhzB3fuft7LMOI/lCSxiBW4L0keRWB1GwGt0Sue BMIQ== X-Gm-Message-State: ANoB5pm0jL1vSppszwn/CGjFv4fQ54sYjsAkGTeBCduPNCJRNggAhLPL 0dBcuIsL+FUl2Sft3XKVJ9lo9sDT+BpZqoofCWWiVw+A+bBwGU7+JOAnd9ZJT9WpnoavRf5G5jo Nsukk39+Sc3IQ X-Received: by 2002:a17:906:df47:b0:7c0:747a:1e0d with SMTP id if7-20020a170906df4700b007c0747a1e0dmr4682884ejc.224.1669673411823; Mon, 28 Nov 2022 14:10:11 -0800 (PST) X-Google-Smtp-Source: AA0mqf425gA6m8pgpUvpIT8KHNPMAzGFBEXZEVPOH9JlVG4aiPoCzI4HDFBWqcj759365DVU9Cme3w== X-Received: by 2002:a17:906:df47:b0:7c0:747a:1e0d with SMTP id if7-20020a170906df4700b007c0747a1e0dmr4682862ejc.224.1669673411347; Mon, 28 Nov 2022 14:10:11 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id 11-20020a170906300b00b007aee947ce9esm5417641ejz.138.2022.11.28.14.10.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 14:10:10 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 3B5057EBE9C; Mon, 28 Nov 2022 23:10:10 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Stanislav Fomichev Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, David Ahern , Jakub Kicinski , Willem de Bruijn , Jesper Dangaard Brouer , Anatoly Burakov , Alexander Lobakin , Magnus Karlsson , Maryam Tahhan , xdp-hints@xdp-project.net, netdev@vger.kernel.org Subject: Re: [xdp-hints] Re: [PATCH bpf-next v2 2/8] bpf: XDP metadata RX kfuncs In-Reply-To: References: <20221121182552.2152891-1-sdf@google.com> <20221121182552.2152891-3-sdf@google.com> <87mt8e2a69.fsf@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Mon, 28 Nov 2022 23:10:10 +0100 Message-ID: <874jui20jh.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Stanislav Fomichev writes: > s > > On Fri, Nov 25, 2022 at 9:53 AM Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> >> Stanislav Fomichev writes: >> >> > There is an ndo handler per kfunc, the verifier replaces a call to the >> > generic kfunc with a call to the per-device one. >> > >> > For XDP, we define a new kfunc set (xdp_metadata_kfunc_ids) which >> > implements all possible metatada kfuncs. Not all devices have to >> > implement them. If kfunc is not supported by the target device, >> > the default implementation is called instead. >> >> BTW, this "the default implementation is called instead" bit is not >> included in this version... :) > > fixup_xdp_kfunc_call should return 0 when the device doesn't have a > kfunc defined and should fallback to the default kfunc implementation, > right? > Or am I missing something? Ohh, right. Maybe add a comment stating this (as I obviously missed it :)) -Toke