From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 3CE3DC433F5
	for <linux-kernel@archiver.kernel.org>; Tue,  2 Nov 2021 16:35:52 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 19BDA61058
	for <linux-kernel@archiver.kernel.org>; Tue,  2 Nov 2021 16:35:52 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S235035AbhKBQiK (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 2 Nov 2021 12:38:10 -0400
Received: from mail.kernel.org ([198.145.29.99]:37196 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S234815AbhKBQLG (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 2 Nov 2021 12:11:06 -0400
Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id D3A9860720;
        Tue,  2 Nov 2021 16:08:31 +0000 (UTC)
Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org)
        by disco-boy.misterjones.org with esmtpsa  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
        (Exim 4.94.2)
        (envelope-from <maz@kernel.org>)
        id 1mhwKr-0035oJ-OQ; Tue, 02 Nov 2021 16:08:29 +0000
Date:   Tue, 02 Nov 2021 16:08:29 +0000
Message-ID: <874k8ua6bm.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Zackary Liu <zackary.liu.pro@gmail.com>
Cc:     masahiroy@kernel.org, ripxorip@gmail.com,
        gregkh@linuxfoundation.org, matthieu.baerts@tessares.net,
        mpe@ellerman.id.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tags: add a space regex to DECLARE_BITMAP
In-Reply-To: <CAOk_PdPzKukZZiQJ2HYN_j3Zw_t7UXUqqcjDb4OBB39o-LbvNA@mail.gmail.com>
References: <20211101155948.GA10424@pc>
        <17bd93d6d81cf267e7d0c63b533cc23f@kernel.org>
        <CAOk_PdPzKukZZiQJ2HYN_j3Zw_t7UXUqqcjDb4OBB39o-LbvNA@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
X-SA-Exim-Connect-IP: 185.219.108.64
X-SA-Exim-Rcpt-To: zackary.liu.pro@gmail.com, masahiroy@kernel.org, ripxorip@gmail.com, gregkh@linuxfoundation.org, matthieu.baerts@tessares.net, mpe@ellerman.id.au, linux-kernel@vger.kernel.org
X-SA-Exim-Mail-From: maz@kernel.org
X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 02 Nov 2021 14:25:19 +0000,
Zackary Liu <zackary.liu.pro@gmail.com> wrote:
> 
> Hi Marc,
> 
> On Tue, Nov 2, 2021 at 12:53 AM Marc Zyngier <maz@kernel.org> wrote:
> >
> > On 2021-11-01 15:59, Zhaoyu Liu wrote:
> > > When "make tags", it prompts a warning:
> > >
> > >     ctags: Warning: drivers/pci/controller/pcie-apple.c:150:
> > >     null expansion of name pattern "\1"
> > >
> > > The reason is that there is an indentation beside arguments of
> > > DECLARE_BITMAP, but it can parsed normally by gtags. It's also
> > > allowed in C.
> > >
> > > So fix this regex temporarily, and wait for better solutions
> > > applied to other regexs.
> > >
> > > Reviewed-by: Marc Zyngier <maz@kernel.org>
> >
> > No, please! I never reviewed this patch. I *suggested*i it [1]
> > as a potential avenue for improvement.
> >
> > You cannot put this tag on a patch unless someone explicitly
> > grants it.
> >
> 
> I'm really sorry that I used the wrong "Reviewed-by" tag,
> Perhaps "Suggested-by" tag would be more appropriate.

Yes, that'd be the right one.

> 
> Sorry again.
> 
> > > Signed-off-by: Zhaoyu Liu <zackary.liu.pro@gmail.com>
> > > ---
> > >  scripts/tags.sh | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/scripts/tags.sh b/scripts/tags.sh
> > > index b24bfaec6290..7e5f19391f20 100755
> > > --- a/scripts/tags.sh
> > > +++ b/scripts/tags.sh
> > > @@ -186,7 +186,7 @@ regex_c=(
> > >
> > >
> '/\<DEFINE_\(RT_MUTEX\|MUTEX\|SEMAPHORE\|SPINLOCK\)(\([[:alnum:]_]*\)/\2/v/'
> > >
> '/\<DEFINE_\(RAW_SPINLOCK\|RWLOCK\|SEQLOCK\)(\([[:alnum:]_]*\)/\2/v/'
> > >       '/\<DECLARE_\(RWSEM\|COMPLETION\)(\([[:alnum:]_]\+\)/\2/v/'
> > > -     '/\<DECLARE_BITMAP(\([[:alnum:]_]*\)/\1/v/'
> > > +     '/\<DECLARE_BITMAP([[:space:]]*\([[:alnum:]_]*\)/\1/v/'
> > >       '/\(^\|\s\)\(\|L\|H\)LIST_HEAD(\([[:alnum:]_]*\)/\3/v/'
> > >       '/\(^\|\s\)RADIX_TREE(\([[:alnum:]_]*\)/\2/v/'
> > >       '/\<DEFINE_PER_CPU([^,]*, *\([[:alnum:]_]*\)/\1/v/'
> >
> > More importantly, and assuming this is the correct approach,
> > why should we limit this to DECLARE_BITMAP()?
>
> I will try to come up with a better approach, and commit [ patch v2
> ] later.

You could try and apply the same approach consistently for all
macros. Since you are using ctags, you're in a good position to test
it and work out whether this is a sensible approach.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.