From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB5A9C433EF for ; Fri, 29 Oct 2021 15:17:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2243461100 for ; Fri, 29 Oct 2021 15:17:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2243461100 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:46784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgTdk-0006tN-0q for qemu-devel@archiver.kernel.org; Fri, 29 Oct 2021 11:17:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgTbx-0005M0-Pb for qemu-devel@nongnu.org; Fri, 29 Oct 2021 11:16:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47543) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgTbu-0002ec-ND for qemu-devel@nongnu.org; Fri, 29 Oct 2021 11:16:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635520561; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=572dH68mNJZpJ5wbBj5rHTHZ6Yd/kWMmi5ePoEJS1fQ=; b=ejT1iI9mHzQzKMnOAH063AJKcTIBDVbD1Czt7mZ20KeGo1MDQWuX9jI5itUe4nn6aCjZWs IhkxCDNBw8c95Sj4nexytF1/rq0/FNgc7OjSL+eJ6OB7wBnT1r71lXSKgAHL2nU66K7RuU k9M9kwbGVxqL9AbtEQwL/kaYxd1RqEY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-299-0LAjoJZIOImLsdm9L0NjfQ-1; Fri, 29 Oct 2021 11:15:58 -0400 X-MC-Unique: 0LAjoJZIOImLsdm9L0NjfQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4717E80A5C0; Fri, 29 Oct 2021 15:15:57 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-7.ams2.redhat.com [10.36.112.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ED9315F4E1; Fri, 29 Oct 2021 15:15:42 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 7BD0911380A7; Fri, 29 Oct 2021 17:15:41 +0200 (CEST) From: Markus Armbruster To: Eric Blake Subject: Re: [PATCH v2 9/9] qapi: Extend -compat to set policy for unstable interfaces References: <20211028102520.747396-1-armbru@redhat.com> <20211028102520.747396-10-armbru@redhat.com> <20211029151009.mv4zqqde6zisywza@redhat.com> Date: Fri, 29 Oct 2021 17:15:41 +0200 In-Reply-To: <20211029151009.mv4zqqde6zisywza@redhat.com> (Eric Blake's message of "Fri, 29 Oct 2021 10:10:09 -0500") Message-ID: <874k8zdfqa.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, pkrempa@redhat.com, berrange@redhat.com, ehabkost@redhat.com, qemu-block@nongnu.org, quintela@redhat.com, libvir-list@redhat.com, philmd@redhat.com, kchamart@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, dgilbert@redhat.com, pbonzini@redhat.com, marcandre.lureau@redhat.com, jsnow@redhat.com, libguestfs@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Eric Blake writes: > On Thu, Oct 28, 2021 at 12:25:20PM +0200, Markus Armbruster wrote: >> New option parameters unstable-input and unstable-output set policy >> for unstable interfaces just like deprecated-input and >> deprecated-output set policy for deprecated interfaces (see commit >> 6dd75472d5 "qemu-options: New -compat to set policy for deprecated >> interfaces"). This is intended for testing users of the management >> interfaces. It is experimental. >> >> For now, this covers only syntactic aspects of QMP, i.e. stuff tagged >> with feature 'unstable'. We may want to extend it to cover semantic >> aspects, or the command line. >> >> Note that there is no good way for management application to detect >> presence of these new option parameters: they are not visible output >> of query-qmp-schema or query-command-line-options. Tolerable, because >> it's meant for testing. If running with -compat fails, skip the test. > > Not to mention, once we finish QAPIfying the command line, we could > make sure it is visible through introspection at that time (it may > require tagging the command line option with a feature, if nothing > else makes it pop through). > >> >> Signed-off-by: Markus Armbruster >> Acked-by: John Snow >> --- >> qapi/compat.json | 6 +++++- >> include/qapi/util.h | 1 + >> qapi/qmp-dispatch.c | 6 ++++++ >> qapi/qobject-output-visitor.c | 8 ++++++-- >> qemu-options.hx | 20 +++++++++++++++++++- >> scripts/qapi/events.py | 10 ++++++---- >> scripts/qapi/schema.py | 10 ++++++---- >> 7 files changed, 49 insertions(+), 12 deletions(-) >> >> diff --git a/qapi/compat.json b/qapi/compat.json >> index 74a8493d3d..9bc9804abb 100644 >> --- a/qapi/compat.json >> +++ b/qapi/compat.json >> @@ -47,9 +47,13 @@ >> # >> # @deprecated-input: how to handle deprecated input (default 'accept') >> # @deprecated-output: how to handle deprecated output (default 'accept') >> +# @unstable-input: how to handle unstable input (default 'accept') >> +# @unstable-output: how to handle unstable output (default 'accept') > > Missing '(since 6.2)' doc tags on the two new policies. Fixing... >> # >> # Since: 6.0 >> ## >> { 'struct': 'CompatPolicy', >> 'data': { '*deprecated-input': 'CompatPolicyInput', >> - '*deprecated-output': 'CompatPolicyOutput' } } >> + '*deprecated-output': 'CompatPolicyOutput', >> + '*unstable-input': 'CompatPolicyInput', >> + '*unstable-output': 'CompatPolicyOutput' } } >> diff --git a/include/qapi/util.h b/include/qapi/util.h >> index 0cc98db9f9..81a2b13a33 100644 >> --- a/include/qapi/util.h >> +++ b/include/qapi/util.h >> @@ -13,6 +13,7 @@ >> >> typedef enum { >> QAPI_DEPRECATED, >> + QAPI_UNSTABLE, >> } QapiSpecialFeature; > >> +++ b/qemu-options.hx >> @@ -3641,7 +3641,9 @@ DEFHEADING(Debug/Expert options:) >> >> DEF("compat", HAS_ARG, QEMU_OPTION_compat, >> "-compat [deprecated-input=accept|reject|crash][,deprecated-output=accept|hide]\n" >> - " Policy for handling deprecated management interfaces\n", >> + " Policy for handling deprecated management interfaces\n" >> + "-compat [unstable-input=accept|reject|crash][,unstable-output=accept|hide]\n" >> + " Policy for handling unstable management interfaces\n", > > It may not be machine-introspectible, but at least we can grep --help > output to see when the policy is usable for testing. > >> QEMU_ARCH_ALL) >> SRST >> ``-compat [deprecated-input=@var{input-policy}][,deprecated-output=@var{output-policy}]`` >> @@ -3659,6 +3661,22 @@ SRST >> Suppress deprecated command results and events >> >> Limitation: covers only syntactic aspects of QMP. >> + >> +``-compat [unstable-input=@var{input-policy}][,unstable-output=@var{output-policy}]`` >> + Set policy for handling unstable management interfaces (experimental): > > Once we QAPIfy the command line, this says we would add the 'unstable' > feature flag to '-compat unstable-input'. How meta ;) Yes :) > And goes along > with your comments earlier in the series about how we may use the > 'unstable' feature even without the 'x-' naming prefix, once it is > machine-detectible. > > With the doc tweak, > Reviewed-by: Eric Blake Thanks!