From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E3AAC433EF for ; Tue, 12 Oct 2021 16:18:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 10DFC60F3A for ; Tue, 12 Oct 2021 16:18:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 10DFC60F3A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7FEC26E976; Tue, 12 Oct 2021 16:18:56 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 72F3D6E838; Tue, 12 Oct 2021 16:18:55 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="227154601" X-IronPort-AV: E=Sophos;i="5.85,368,1624345200"; d="scan'208";a="227154601" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2021 09:16:23 -0700 X-IronPort-AV: E=Sophos;i="5.85,368,1624345200"; d="scan'208";a="491043613" Received: from annahenx-mobl.ger.corp.intel.com (HELO localhost) ([10.251.209.214]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2021 09:16:20 -0700 From: Jani Nikula To: Matthew Brost , Thanneeru Srinivasulu Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, michal.wajdeczko@intel.com, Joonas Lahtinen Subject: Re: [Intel-gfx] [PATCH 1/4] drm/i915/huc: Use i915_probe_error to report early CTB failures In-Reply-To: <20211011181056.GA6310@jons-linux-dev-box> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20211011152106.3424810-1-thanneeru.srinivasulu@intel.com> <20211011152106.3424810-2-thanneeru.srinivasulu@intel.com> <20211011181056.GA6310@jons-linux-dev-box> Date: Tue, 12 Oct 2021 19:16:17 +0300 Message-ID: <874k9mz0a6.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 11 Oct 2021, Matthew Brost wrote: > On Mon, Oct 11, 2021 at 08:51:03PM +0530, Thanneeru Srinivasulu wrote: >> Replace DRM_ERROR with CT_PROBE_ERROR to report early CTB failures. >> >> Signed-off-by: Thanneeru Srinivasulu > > Reviewed-by: Matthew Brost > >> --- >> drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c >> index 0a3504bc0b61..83764db0fd6d 100644 >> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c >> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c >> @@ -191,8 +191,8 @@ static int ct_register_buffer(struct intel_guc_ct *ct, u32 type, >> err = guc_action_register_ct_buffer(ct_to_guc(ct), type, >> desc_addr, buff_addr, size); >> if (unlikely(err)) >> - CT_ERROR(ct, "Failed to register %s buffer (%pe)\n", >> - guc_ct_buffer_type_to_str(type), ERR_PTR(err)); >> + CT_PROBE_ERROR(ct, "Failed to register %s buffer (%pe)\n", >> + guc_ct_buffer_type_to_str(type), ERR_PTR(err)); Please tell me why we are adding not just i915-specific logging helpers, but file specific ones? To be honest I'd like to see all of the CT_ERROR, CT_DEBUG, CT_PROBE_ERROR macros just gone. BR, Jani. >> return err; >> } >> >> -- >> 2.25.1 >> -- Jani Nikula, Intel Open Source Graphics Center