From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35C683FCB for ; Fri, 24 Sep 2021 08:04:05 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10116"; a="224069854" X-IronPort-AV: E=Sophos;i="5.85,319,1624345200"; d="scan'208";a="224069854" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2021 01:04:04 -0700 X-IronPort-AV: E=Sophos;i="5.85,319,1624345200"; d="scan'208";a="551488631" Received: from avanhout-mobl.ger.corp.intel.com (HELO localhost) ([10.249.37.153]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2021 01:03:37 -0700 From: Jani Nikula To: Doug Anderson , Linus Walleij Cc: Thierry Reding , Rob Herring , Sam Ravnborg , "open list\:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Steev Klimaszewski , "open list\:DRM PANEL DRIVERS" , MSM , David Airlie , Maarten Lankhorst , Thomas Zimmermann , Bjorn Andersson , Daniel Vetter , Maxime Ripard , Adam Ford , Al Viro , Alexandre Belloni , Alexandre Torgue , Andreas Kemnade , Andrey Zhizhikin , Anson Huang , Arnd Bergmann , Catalin Marinas , Chen-Yu Tsai , Claudiu Beznea , Corentin Labbe , Daniel Thompson , Dmitry Baryshkov , Dmitry Osipenko , Emil Velikov , Enric Balletbo i Serra , Eugen Hristev , Fabio Estevam , Fabrice Gasnier , Florian Fainelli , Geert Uytterhoeven , Grygorii Strashko , Guido =?utf-8?Q?G=C3=BCnther?= , Jagan Teki , Jernej Skrabec , Joel Stanley , Jonathan Hunter , Kees Cook , Krzysztof Kozlowski , Krzysztof Kozlowski , Lionel Debieve , Liviu Dudau , Lorenzo Pieralisi , Ludovic Desroches , Magnus Damm , Manivannan Sadhasivam , Marek Szyprowski , Martin =?utf-8?Q?J=C3=BCcker?= , Matthias Brugger , Michael Walle , NXP Linux Team , Nicolas Ferre , Nishanth Menon , Olivier Moysan , Otavio Salvador , Pengutronix Kernel Team , Razvan Stefanescu , Robert Richter , Russell King , Sascha Hauer , Shawn Guo , Stefan Wahren , Sudeep Holla , Tony Lindgren , Viresh Kumar , Vladimir Zapolskiy , Will Deacon , William Cohen , Linux ARM , linux-kernel , Linux-OMAP , Linux-Renesas , linux-samsung-soc , linux-sunxi@lists.linux.dev, linux-tegra , =?utf-8?Q?=C5=81ukasz?= Stelmach , Stanislav Lisovskiy Subject: Re: [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210914202202.1702601-1-dianders@chromium.org> Date: Fri, 24 Sep 2021 11:03:34 +0300 Message-ID: <874kaabdt5.fsf@intel.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, 20 Sep 2021, Doug Anderson wrote: > Pushed all 15 to drm-misc-next. ... > e8de4d55c259 drm/edid: Use new encoded panel id style for quirks matching > d9f91a10c3e8 drm/edid: Allow querying/working with the panel ID from the = EDID Hi Doug, Stan's reporting "initializer element is not constant" issues here that were discussed before [1]. I wonder what gives, you said you'd hit them on a draft version, but not with what was merged, and I can't reproduce this either. Curious. BR, Jani. In file included from drivers/gpu/drm/drm_edid.c:42:0: ./include/drm/drm_edid.h:525:2: error: initializer element is not constant ((((u32)((vend)[0]) - '@') & 0x1f) << 26 | \ ^ drivers/gpu/drm/drm_edid.c:111:14: note: in expansion of macro =E2=80=98drm= _edid_encode_panel_id=E2=80=99 .panel_id =3D drm_edid_encode_panel_id(vend, product_id), \ ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/drm_edid.c:120:2: note: in expansion of macro =E2=80=98EDID= _QUIRK=E2=80=99 EDID_QUIRK("ACR", 44358, EDID_QUIRK_PREFER_LARGE_60), ^~~~~~~~~~ ./include/drm/drm_edid.h:525:2: note: (near initialization for =E2=80=98edi= d_quirk_list[0].panel_id=E2=80=99) ((((u32)((vend)[0]) - '@') & 0x1f) << 26 | \ ^ drivers/gpu/drm/drm_edid.c:111:14: note: in expansion of macro =E2=80=98drm= _edid_encode_panel_id=E2=80=99 .panel_id =3D drm_edid_encode_panel_id(vend, product_id), \ ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/drm_edid.c:120:2: note: in expansion of macro =E2=80=98EDID= _QUIRK=E2=80=99 EDID_QUIRK("ACR", 44358, EDID_QUIRK_PREFER_LARGE_60), ^~~~~~~~~~ [1] https://lore.kernel.org/all/CAD=3DFV=3DXHvFq5+Rtax7WNq2-BieQr-BM4UnmOcm= a_eTzkX2ZtNA@mail.gmail.com/ --=20 Jani Nikula, Intel Open Source Graphics Center