[RFC PATCH] tests/tcg: skip the signals test for hppa for now

[RFC PATCH] tests/tcg: skip the signals test for hppa for now

[Alex Bennée]

While Richard has some patches that fix the instability on other
architectures the hppa signal support still needs vdso support before
we can make this reliable. So for now skip the test.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Richard Henderson <richard.henderson@linaro.org>
---
 tests/tcg/hppa/Makefile.target | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/tcg/hppa/Makefile.target b/tests/tcg/hppa/Makefile.target
index 8bf01966bd..71791235f6 100644
--- a/tests/tcg/hppa/Makefile.target
+++ b/tests/tcg/hppa/Makefile.target
@@ -4,3 +4,7 @@
 
 # On parisc Linux supports 4K/16K/64K (but currently only 4k works)
 EXTRA_RUNS+=run-test-mmap-4096 # run-test-mmap-16384 run-test-mmap-65536
+
+# There is a race that causes this to fail about 1% of the time
+run-signals: signals
+	$(call skip-test, $<, "BROKEN awaiting vdso support")
-- 
2.20.1

Re: [RFC PATCH] tests/tcg: skip the signals test for hppa for now

[Richard Henderson]

On 6/18/21 2:32 AM, Alex Bennée wrote:
> While Richard has some patches that fix the instability on other
> architectures the hppa signal support still needs vdso support before
> we can make this reliable. So for now skip the test.

Patches for a vdso posted.

r~

> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tests/tcg/hppa/Makefile.target | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tests/tcg/hppa/Makefile.target b/tests/tcg/hppa/Makefile.target
> index 8bf01966bd..71791235f6 100644
> --- a/tests/tcg/hppa/Makefile.target
> +++ b/tests/tcg/hppa/Makefile.target
> @@ -4,3 +4,7 @@
>   
>   # On parisc Linux supports 4K/16K/64K (but currently only 4k works)
>   EXTRA_RUNS+=run-test-mmap-4096 # run-test-mmap-16384 run-test-mmap-65536
> +
> +# There is a race that causes this to fail about 1% of the time
> +run-signals: signals
> +	$(call skip-test, $<, "BROKEN awaiting vdso support")
> 

Re: [RFC PATCH] tests/tcg: skip the signals test for hppa for now

[Alex Bennée]

Richard Henderson <richard.henderson@linaro.org> writes:

> On 6/18/21 2:32 AM, Alex Bennée wrote:
>> While Richard has some patches that fix the instability on other
>> architectures the hppa signal support still needs vdso support before
>> we can make this reliable. So for now skip the test.
>
> Patches for a vdso posted.

Ah ok I shall look on Monday. You sure have a soft spot for that old
architecture ;-)

>
> r~
>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Cc: Richard Henderson <richard.henderson@linaro.org>
>> ---
>>   tests/tcg/hppa/Makefile.target | 4 ++++
>>   1 file changed, 4 insertions(+)
>> diff --git a/tests/tcg/hppa/Makefile.target
>> b/tests/tcg/hppa/Makefile.target
>> index 8bf01966bd..71791235f6 100644
>> --- a/tests/tcg/hppa/Makefile.target
>> +++ b/tests/tcg/hppa/Makefile.target
>> @@ -4,3 +4,7 @@
>>     # On parisc Linux supports 4K/16K/64K (but currently only 4k
>> works)
>>   EXTRA_RUNS+=run-test-mmap-4096 # run-test-mmap-16384 run-test-mmap-65536
>> +
>> +# There is a race that causes this to fail about 1% of the time
>> +run-signals: signals
>> +	$(call skip-test, $<, "BROKEN awaiting vdso support")
>> 


-- 
Alex Bennée