From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE0E3C433DB for ; Mon, 11 Jan 2021 11:48:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D0A5224F9 for ; Mon, 11 Jan 2021 11:48:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730252AbhAKLsl (ORCPT ); Mon, 11 Jan 2021 06:48:41 -0500 Received: from m43-15.mailgun.net ([69.72.43.15]:40103 "EHLO m43-15.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729675AbhAKLsl (ORCPT ); Mon, 11 Jan 2021 06:48:41 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1610365700; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=e2RKIfh/3Dgq5OF2y0vpSR1viIDQKn/3YAJh2Hfy6ZE=; b=xiPM3FWlEZHn3CmKafRYMnK4lSnH3TdS4zsl+n0onjnT+TFB+zMCtQGG53ckJ/zdROHB1JI9 mTEAth0NJkV9DOgifaEWWQRM+PYLth0J3m/LghXWlLaSIO0RGzexKrMR0kt/rRQYHWFbUAEK xFsBETLohwW8BUOYe/FNnT883Yw= X-Mailgun-Sending-Ip: 69.72.43.15 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n08.prod.us-east-1.postgun.com with SMTP id 5ffc3ac346a6c7cde7a811b5 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 11 Jan 2021 11:47:15 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id CB814C433CA; Mon, 11 Jan 2021 11:47:14 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 78830C433C6; Mon, 11 Jan 2021 11:47:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 78830C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Arnd Bergmann Cc: Maya Erez , "David S. Miller" , Jakub Kicinski , Arnd Bergmann , "John W. Linville" , Vladimir Kondratiev , linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/7] wil6210: select CONFIG_CRC32 References: <20210103213645.1994783-1-arnd@kernel.org> <20210103213645.1994783-4-arnd@kernel.org> Date: Mon, 11 Jan 2021 13:47:09 +0200 In-Reply-To: <20210103213645.1994783-4-arnd@kernel.org> (Arnd Bergmann's message of "Sun, 3 Jan 2021 22:36:20 +0100") Message-ID: <874kjnk85e.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Arnd Bergmann writes: > From: Arnd Bergmann > > Without crc32, the driver fails to link: > > arm-linux-gnueabi-ld: drivers/net/wireless/ath/wil6210/fw.o: in function `wil_fw_verify': > fw.c:(.text+0x74c): undefined reference to `crc32_le' > arm-linux-gnueabi-ld: drivers/net/wireless/ath/wil6210/fw.o:fw.c:(.text+0x758): more undefined references to `crc32_le' follow > > Fixes: 151a9706503f ("wil6210: firmware download") > Signed-off-by: Arnd Bergmann I'll queue this to v5.11. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches