From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30558C433E1 for ; Fri, 24 Jul 2020 00:29:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E9E4208A9 for ; Fri, 24 Jul 2020 00:29:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728390AbgGXA3V (ORCPT ); Thu, 23 Jul 2020 20:29:21 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:38988 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728008AbgGXA3U (ORCPT ); Thu, 23 Jul 2020 20:29:20 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 06O03fUV149644; Thu, 23 Jul 2020 20:29:07 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 32facss112-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Jul 2020 20:29:07 -0400 Received: from m0098413.ppops.net (m0098413.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 06O04HcY152265; Thu, 23 Jul 2020 20:29:06 -0400 Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0b-001b2d01.pphosted.com with ESMTP id 32facss10w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Jul 2020 20:29:06 -0400 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 06O0JemK015067; Fri, 24 Jul 2020 00:29:06 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma01wdc.us.ibm.com with ESMTP id 32brq9ge7d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Jul 2020 00:29:06 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 06O0T5wW52494840 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Jul 2020 00:29:05 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 70272AC05E; Fri, 24 Jul 2020 00:29:05 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0E837AC059; Fri, 24 Jul 2020 00:29:00 +0000 (GMT) Received: from morokweng.localdomain (unknown [9.163.53.35]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTPS; Fri, 24 Jul 2020 00:28:59 +0000 (GMT) References: <159524918900.20855.17709718993097359220.stgit@hbathini.in.ibm.com> <159524964786.20855.15850644504721928289.stgit@hbathini.in.ibm.com> User-agent: mu4e 1.2.0; emacs 26.3 From: Thiago Jung Bauermann To: Hari Bathini Cc: Michael Ellerman , Andrew Morton , kernel test robot , Pingfan Liu , Kexec-ml , Mimi Zohar , Nayna Jain , Petr Tesarik , Mahesh J Salgaonkar , Sourabh Jain , lkml , linuxppc-dev , Eric Biederman , Dave Young , Vivek Goyal Subject: Re: [PATCH v4 09/12] ppc64/kexec_file: setup backup region for kdump kernel In-reply-to: <159524964786.20855.15850644504721928289.stgit@hbathini.in.ibm.com> Date: Thu, 23 Jul 2020 21:28:55 -0300 Message-ID: <874kpx69iw.fsf@morokweng.localdomain> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-07-23_09:2020-07-23,2020-07-23 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 adultscore=0 suspectscore=0 clxscore=1015 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007230165 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hari Bathini writes: > Though kdump kernel boots from loaded address, the first 64K bytes > of it is copied down to real 0. So, setup a backup region to copy > the first 64K bytes of crashed kernel, in purgatory, before booting > into kdump kernel. Also, update reserve map with backup region and > crashed kernel's memory to avoid kdump kernel from accidentially > using that memory. > > Reported-by: kernel test robot > [lkp: In v1, purgatory() declaration was missing] > Signed-off-by: Hari Bathini Reviewed-by: Thiago Jung Bauermann Just one minor comment below: > @@ -1047,13 +1120,26 @@ int setup_new_fdt_ppc64(const struct kimage *image, void *fdt, > goto out; > } > > - /* Ensure we don't touch crashed kernel's memory */ > - ret = fdt_add_mem_rsv(fdt, 0, crashk_res.start); > + /* > + * Ensure we don't touch crashed kernel's memory except the > + * first 64K of RAM, which will be backed up. > + */ > + ret = fdt_add_mem_rsv(fdt, BACKUP_SRC_SIZE, I know BACKUP_SRC_START is 0, but please forgive my pedantry when I say that I think it's clearer if the start address above is changed to BACKUP_SRC_START + BACKUP_SRC_SIZE... > + crashk_res.start - BACKUP_SRC_SIZE); > if (ret) { > pr_err("Error reserving crash memory: %s\n", > fdt_strerror(ret)); > goto out; > } > + > + /* Ensure backup region is not used by kdump/capture kernel */ > + ret = fdt_add_mem_rsv(fdt, image->arch.backup_start, > + BACKUP_SRC_SIZE); > + if (ret) { > + pr_err("Error reserving memory for backup: %s\n", > + fdt_strerror(ret)); > + goto out; > + } > } > > out: -- Thiago Jung Bauermann IBM Linux Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8150AC433E1 for ; Fri, 24 Jul 2020 00:31:18 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3B1320888 for ; Fri, 24 Jul 2020 00:31:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3B1320888 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4BCVVr0pgKzDrfy for ; Fri, 24 Jul 2020 10:31:16 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4BCVSY4qZWzDrfT for ; Fri, 24 Jul 2020 10:29:17 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) by bilbo.ozlabs.org (Postfix) with ESMTP id 4BCVSY44kwz8t40 for ; Fri, 24 Jul 2020 10:29:17 +1000 (AEST) Received: by ozlabs.org (Postfix) id 4BCVSY3jMKz9sR4; Fri, 24 Jul 2020 10:29:17 +1000 (AEST) Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com; envelope-from=bauerman@linux.ibm.com; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BCVSY04JRz9sPB for ; Fri, 24 Jul 2020 10:29:16 +1000 (AEST) Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 06O03fUV149644; Thu, 23 Jul 2020 20:29:07 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 32facss112-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Jul 2020 20:29:07 -0400 Received: from m0098413.ppops.net (m0098413.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 06O04HcY152265; Thu, 23 Jul 2020 20:29:06 -0400 Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0b-001b2d01.pphosted.com with ESMTP id 32facss10w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Jul 2020 20:29:06 -0400 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 06O0JemK015067; Fri, 24 Jul 2020 00:29:06 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma01wdc.us.ibm.com with ESMTP id 32brq9ge7d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Jul 2020 00:29:06 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 06O0T5wW52494840 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Jul 2020 00:29:05 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 70272AC05E; Fri, 24 Jul 2020 00:29:05 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0E837AC059; Fri, 24 Jul 2020 00:29:00 +0000 (GMT) Received: from morokweng.localdomain (unknown [9.163.53.35]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTPS; Fri, 24 Jul 2020 00:28:59 +0000 (GMT) References: <159524918900.20855.17709718993097359220.stgit@hbathini.in.ibm.com> <159524964786.20855.15850644504721928289.stgit@hbathini.in.ibm.com> User-agent: mu4e 1.2.0; emacs 26.3 From: Thiago Jung Bauermann To: Hari Bathini Subject: Re: [PATCH v4 09/12] ppc64/kexec_file: setup backup region for kdump kernel In-reply-to: <159524964786.20855.15850644504721928289.stgit@hbathini.in.ibm.com> Date: Thu, 23 Jul 2020 21:28:55 -0300 Message-ID: <874kpx69iw.fsf@morokweng.localdomain> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-07-23_09:2020-07-23, 2020-07-23 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 adultscore=0 suspectscore=0 clxscore=1015 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007230165 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel test robot , Pingfan Liu , Nayna Jain , Kexec-ml , Mahesh J Salgaonkar , Mimi Zohar , lkml , linuxppc-dev , Sourabh Jain , Petr Tesarik , Andrew Morton , Dave Young , Vivek Goyal , Eric Biederman Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hari Bathini writes: > Though kdump kernel boots from loaded address, the first 64K bytes > of it is copied down to real 0. So, setup a backup region to copy > the first 64K bytes of crashed kernel, in purgatory, before booting > into kdump kernel. Also, update reserve map with backup region and > crashed kernel's memory to avoid kdump kernel from accidentially > using that memory. > > Reported-by: kernel test robot > [lkp: In v1, purgatory() declaration was missing] > Signed-off-by: Hari Bathini Reviewed-by: Thiago Jung Bauermann Just one minor comment below: > @@ -1047,13 +1120,26 @@ int setup_new_fdt_ppc64(const struct kimage *image, void *fdt, > goto out; > } > > - /* Ensure we don't touch crashed kernel's memory */ > - ret = fdt_add_mem_rsv(fdt, 0, crashk_res.start); > + /* > + * Ensure we don't touch crashed kernel's memory except the > + * first 64K of RAM, which will be backed up. > + */ > + ret = fdt_add_mem_rsv(fdt, BACKUP_SRC_SIZE, I know BACKUP_SRC_START is 0, but please forgive my pedantry when I say that I think it's clearer if the start address above is changed to BACKUP_SRC_START + BACKUP_SRC_SIZE... > + crashk_res.start - BACKUP_SRC_SIZE); > if (ret) { > pr_err("Error reserving crash memory: %s\n", > fdt_strerror(ret)); > goto out; > } > + > + /* Ensure backup region is not used by kdump/capture kernel */ > + ret = fdt_add_mem_rsv(fdt, image->arch.backup_start, > + BACKUP_SRC_SIZE); > + if (ret) { > + pr_err("Error reserving memory for backup: %s\n", > + fdt_strerror(ret)); > + goto out; > + } > } > > out: -- Thiago Jung Bauermann IBM Linux Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5] helo=mx0a-001b2d01.pphosted.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jylaM-0004Cz-7G for kexec@lists.infradead.org; Fri, 24 Jul 2020 00:29:15 +0000 References: <159524918900.20855.17709718993097359220.stgit@hbathini.in.ibm.com> <159524964786.20855.15850644504721928289.stgit@hbathini.in.ibm.com> From: Thiago Jung Bauermann Subject: Re: [PATCH v4 09/12] ppc64/kexec_file: setup backup region for kdump kernel In-reply-to: <159524964786.20855.15850644504721928289.stgit@hbathini.in.ibm.com> Date: Thu, 23 Jul 2020 21:28:55 -0300 Message-ID: <874kpx69iw.fsf@morokweng.localdomain> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Hari Bathini Cc: kernel test robot , Pingfan Liu , Michael Ellerman , Nayna Jain , Kexec-ml , Mahesh J Salgaonkar , Mimi Zohar , lkml , linuxppc-dev , Sourabh Jain , Petr Tesarik , Andrew Morton , Dave Young , Vivek Goyal , Eric Biederman Hari Bathini writes: > Though kdump kernel boots from loaded address, the first 64K bytes > of it is copied down to real 0. So, setup a backup region to copy > the first 64K bytes of crashed kernel, in purgatory, before booting > into kdump kernel. Also, update reserve map with backup region and > crashed kernel's memory to avoid kdump kernel from accidentially > using that memory. > > Reported-by: kernel test robot > [lkp: In v1, purgatory() declaration was missing] > Signed-off-by: Hari Bathini Reviewed-by: Thiago Jung Bauermann Just one minor comment below: > @@ -1047,13 +1120,26 @@ int setup_new_fdt_ppc64(const struct kimage *image, void *fdt, > goto out; > } > > - /* Ensure we don't touch crashed kernel's memory */ > - ret = fdt_add_mem_rsv(fdt, 0, crashk_res.start); > + /* > + * Ensure we don't touch crashed kernel's memory except the > + * first 64K of RAM, which will be backed up. > + */ > + ret = fdt_add_mem_rsv(fdt, BACKUP_SRC_SIZE, I know BACKUP_SRC_START is 0, but please forgive my pedantry when I say that I think it's clearer if the start address above is changed to BACKUP_SRC_START + BACKUP_SRC_SIZE... > + crashk_res.start - BACKUP_SRC_SIZE); > if (ret) { > pr_err("Error reserving crash memory: %s\n", > fdt_strerror(ret)); > goto out; > } > + > + /* Ensure backup region is not used by kdump/capture kernel */ > + ret = fdt_add_mem_rsv(fdt, image->arch.backup_start, > + BACKUP_SRC_SIZE); > + if (ret) { > + pr_err("Error reserving memory for backup: %s\n", > + fdt_strerror(ret)); > + goto out; > + } > } > > out: -- Thiago Jung Bauermann IBM Linux Technology Center _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec