All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Li Qiang <liq3ea@163.com>
Cc: lvivier@redhat.com, thuth@redhat.com, liq3ea@gmail.com,
	qemu-devel@nongnu.org, eric.auger@redhat.com,
	pbonzini@redhat.com
Subject: Re: [PATCH v2] tests: qmp-cmd-test: fix memory leak
Date: Thu, 16 Jul 2020 07:59:04 +0200	[thread overview]
Message-ID: <874kq8roev.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20200715154117.15456-1-liq3ea@163.com> (Li Qiang's message of "Wed, 15 Jul 2020 08:41:17 -0700")

Li Qiang <liq3ea@163.com> writes:

> Properly free each test response to avoid memory leak and separate
> qtest_qmp() calls with spare lines, in a consistent manner.
>
> Fixes: 5b88849e7b9("tests/qmp-cmd-test: Add
> qmp/object-add-failure-modes"

The patch also fixes leaks introduced in 442b09b83d and 9fc719b869,
actually.  At least it should, but the patch appears to be incomplete.

>
> Reviewed-by: Eric Auger <eric.auger@redhat.com>
> Signed-off-by: Li Qiang <liq3ea@163.com>
> ---
> Change sincve v1: add detailed commit message
>  
> tests/qtest/qmp-cmd-test.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/tests/qtest/qmp-cmd-test.c b/tests/qtest/qmp-cmd-test.c
> index c68f99f659..f7b1aa7fdc 100644
> --- a/tests/qtest/qmp-cmd-test.c
> +++ b/tests/qtest/qmp-cmd-test.c
> @@ -230,6 +230,8 @@ static void test_object_add_failure_modes(void)
   static void test_object_add_failure_modes(void)
   {
       QTestState *qts;
       QDict *resp;

       /* attempt to create an object without props */
       qts = qtest_init(common_args);
       resp = qtest_qmp(qts, "{'execute': 'object-add', 'arguments':"
                        " {'qom-type': 'memory-backend-ram', 'id': 'ram1' } }");
       g_assert_nonnull(resp);
       qmp_assert_error_class(resp, "GenericError");

Doesn't @resp leak here, too?

       /* attempt to create an object without qom-type */
       resp = qtest_qmp(qts, "{'execute': 'object-add', 'arguments':"
                        " {'id': 'ram1' } }");
       g_assert_nonnull(resp);
       qmp_assert_error_class(resp, "GenericError");

Likewise.

       /* attempt to delete an object that does not exist */
       resp = qtest_qmp(qts, "{'execute': 'object-del', 'arguments':"
                        " {'id': 'ram1' } }");
       g_assert_nonnull(resp);
       qmp_assert_error_class(resp, "GenericError");

Likewise.

       /* attempt to create 2 objects with duplicate id */
       resp = qtest_qmp(qts, "{'execute': 'object-add', 'arguments':"
                        " {'qom-type': 'memory-backend-ram', 'id': 'ram1',"
>                       " 'props': {'size': 1048576 } } }");
>      g_assert_nonnull(resp);
>      g_assert(qdict_haskey(resp, "return"));
> +    qobject_unref(resp);
> +
>      resp = qtest_qmp(qts, "{'execute': 'object-add', 'arguments':"
>                       " {'qom-type': 'memory-backend-ram', 'id': 'ram1',"
>                       " 'props': {'size': 1048576 } } }");
       g_assert_nonnull(resp);
       qmp_assert_error_class(resp, "GenericError");

Likewise.

       /* delete ram1 object */
       resp = qtest_qmp(qts, "{'execute': 'object-del', 'arguments':"
> @@ -241,6 +243,7 @@ static void test_object_add_failure_modes(void)
>                       " {'id': 'ram1' } }");
>      g_assert_nonnull(resp);
>      g_assert(qdict_haskey(resp, "return"));
> +    qobject_unref(resp);
>  
>      /* attempt to create an object with a property of a wrong type */
>      resp = qtest_qmp(qts, "{'execute': 'object-add', 'arguments':"
                        " {'qom-type': 'memory-backend-ram', 'id': 'ram1',"
                        " 'props': {'size': '1048576' } } }");
> @@ -249,17 +252,20 @@ static void test_object_add_failure_modes(void)
>      g_assert_nonnull(resp);
>      /* now do it right */
>      qmp_assert_error_class(resp, "GenericError");

Likewise.

> +
>      resp = qtest_qmp(qts, "{'execute': 'object-add', 'arguments':"
>                       " {'qom-type': 'memory-backend-ram', 'id': 'ram1',"
>                       " 'props': {'size': 1048576 } } }");
>      g_assert_nonnull(resp);
>      g_assert(qdict_haskey(resp, "return"));
> +    qobject_unref(resp);
>  
>      /* delete ram1 object */
>      resp = qtest_qmp(qts, "{'execute': 'object-del', 'arguments':"
>                       " {'id': 'ram1' } }");
>      g_assert_nonnull(resp);
>      g_assert(qdict_haskey(resp, "return"));
> +    qobject_unref(resp);
>  
>      /* attempt to create an object without the id */
>      resp = qtest_qmp(qts, "{'execute': 'object-add', 'arguments':"
                        " {'qom-type': 'memory-backend-ram',"
> @@ -267,18 +273,21 @@ static void test_object_add_failure_modes(void)
>                       " 'props': {'size': 1048576 } } }");
>      g_assert_nonnull(resp);
>      qmp_assert_error_class(resp, "GenericError");

Likewise.

> +
>      /* now do it right */
>      resp = qtest_qmp(qts, "{'execute': 'object-add', 'arguments':"
>                       " {'qom-type': 'memory-backend-ram', 'id': 'ram1',"
>                       " 'props': {'size': 1048576 } } }");
>      g_assert_nonnull(resp);
>      g_assert(qdict_haskey(resp, "return"));
> +    qobject_unref(resp);
>  
>      /* delete ram1 object */
>      resp = qtest_qmp(qts, "{'execute': 'object-del', 'arguments':"
>                       " {'id': 'ram1' } }");
>      g_assert_nonnull(resp);
>      g_assert(qdict_haskey(resp, "return"));
> +    qobject_unref(resp);
>  
>      /* attempt to set a non existing property */
>      resp = qtest_qmp(qts, "{'execute': 'object-add', 'arguments':"
                        " {'qom-type': 'memory-backend-ram', 'id': 'ram1',"
> @@ -286,23 +295,27 @@ static void test_object_add_failure_modes(void)
>                       " 'props': {'sized': 1048576 } } }");
>      g_assert_nonnull(resp);
>      qmp_assert_error_class(resp, "GenericError");

Likewise.

> +
>      /* now do it right */
>      resp = qtest_qmp(qts, "{'execute': 'object-add', 'arguments':"
>                       " {'qom-type': 'memory-backend-ram', 'id': 'ram1',"
>                       " 'props': {'size': 1048576 } } }");
>      g_assert_nonnull(resp);
>      g_assert(qdict_haskey(resp, "return"));
> +    qobject_unref(resp);
>  
>      /* delete ram1 object without id */
>      resp = qtest_qmp(qts, "{'execute': 'object-del', 'arguments':"
>                       " {'ida': 'ram1' } }");
>      g_assert_nonnull(resp);
> +    qobject_unref(resp);
>  
>      /* delete ram1 object */
>      resp = qtest_qmp(qts, "{'execute': 'object-del', 'arguments':"
>                       " {'id': 'ram1' } }");
>      g_assert_nonnull(resp);
>      g_assert(qdict_haskey(resp, "return"));
> +    qobject_unref(resp);
>  
>      /* delete ram1 object that does not exist anymore*/
>      resp = qtest_qmp(qts, "{'execute': 'object-del', 'arguments':"
                        " {'id': 'ram1' } }");
       g_assert_nonnull(resp);
       qmp_assert_error_class(resp, "GenericError");

Likewise.

       qtest_quit(qts);
   }



  reply	other threads:[~2020-07-16  6:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15 15:41 [PATCH v2] tests: qmp-cmd-test: fix memory leak Li Qiang
2020-07-16  5:59 ` Markus Armbruster [this message]
2020-07-16  6:43   ` Li Qiang
2020-07-16  9:52     ` Markus Armbruster
2020-07-16 10:33       ` Li Qiang
2020-07-16 10:47         ` Thomas Huth
2020-07-16  7:56 ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kq8roev.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=liq3ea@163.com \
    --cc=liq3ea@gmail.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.