From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAB87C433DF for ; Fri, 15 May 2020 09:11:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87E8C20709 for ; Fri, 15 May 2020 09:11:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="y7KyQS0m" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728007AbgEOJL4 (ORCPT ); Fri, 15 May 2020 05:11:56 -0400 Received: from esa1.microchip.iphmx.com ([68.232.147.91]:3742 "EHLO esa1.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727869AbgEOJLz (ORCPT ); Fri, 15 May 2020 05:11:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1589533914; x=1621069914; h=references:from:to:cc:subject:in-reply-to:date: message-id:mime-version; bh=wmtlMa/ByzxofhuCC0VPeSnxK6BCfzWRYql8RxVBaqc=; b=y7KyQS0mKcN2rFGxAMJaAIlyjPJAAgA/EqNDb45NmLVoJ5vX/5DDw9Iv 5jcdFHSx0rb0+y2f0gXb+G8Nn9Bon0BLqecFg5CMOdB8s2JIftAGoutfh FoK8F3/fMZLIf6337zaLKxJI6hgAUMuqxLl90CMsWea4bLbOhnnW7Cqlg phMynerm6SquNAwGZ17jESdVZWf4TUfP69HsUZBjxLFwh69s1jCljQIio L4s9iefzMVLrJGyVxdiqDgyrERV9JWKVI+YLjwbMC62vSteGqAl4xOo7T ZYHaa9OFmrSyCOnUoy3aESAnffn8pHFsG93SEdc/zTtRu9qu7dyxA7ovy w==; IronPort-SDR: DiM+U75P+/Md9FzuxnzG9/z0ceXFZvbHHtzFIn11OpL0g9Q1x1Uby3/VZY5m1NeVYWhvUBPmE+ fgXUBBDmoZtQ367KyOjQZknEXfD5iM3FrLkBAERTap365oNNgrj1v8ezcplKZf610CTi+9QIoE o5MSEPl/7koBuzmySNOL7Y4LO3u9rXNzVcL3jJlTliM6j+9gKvuMN9IwP6het51vlvoYSL5FN4 fOUTEcECWvT0h+Gp2PovBvNtR1UGsmCCQYbZxYGTpCE4WgWkOBOKcEjLw/SxtEbpYrTSxwouNm V6c= X-IronPort-AV: E=Sophos;i="5.73,394,1583218800"; d="scan'208";a="79762318" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 15 May 2020 02:11:52 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 15 May 2020 02:11:52 -0700 Received: from soft-dev15.microsemi.net.microchip.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 15 May 2020 02:11:49 -0700 References: <20200513140031.25633-1-lars.povlsen@microchip.com> <20200513140031.25633-2-lars.povlsen@microchip.com> <20200513142050.GH4803@sirena.org.uk> <20200514130407.guyk3r4ltjvszy5s@mobilestation> From: Lars Povlsen To: Serge Semin List-Id: CC: Mark Brown , Serge Semin , Lars Povlsen , SoC Team , Microchip Linux Driver Support , , , , , Alexandre Belloni , Andy Shevchenko Subject: Re: [PATCH 01/10] spi: dw: Add support for polled operation via no IRQ specified in DT In-Reply-To: <20200514130407.guyk3r4ltjvszy5s@mobilestation> Date: Fri, 15 May 2020 11:11:48 +0200 Message-ID: <874kshpnor.fsf@soft-dev15.microsemi.net> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Serge Semin writes: > Hi Mark > > On Wed, May 13, 2020 at 03:20:50PM +0100, Mark Brown wrote: >> On Wed, May 13, 2020 at 04:00:22PM +0200, Lars Povlsen wrote: >> > With this change a SPI controller can be added without having a IRQ >> > associated, and causing all transfers to be polled. For SPI controllers >> > without DMA, this can significantly improve performance by less >> > interrupt handling overhead. >> >> This overlaps substantially with some work that Serge Semin (CCed) has >> in progress, please coordinate with him. > > Thanks for copying me these mails. I haven't been Cc'ed in the series and > hasn't been subscribed to the SPI mailing list, so I would have definitely > missed that. > > I would like to coordinate my efforts with Lars. I'll have the patchset reviewed > soon in addition providing my comments/suggestions of how to make it useful for > both mine and Lars solution. Serge - thanks for taking on this. Note that my primary concern now is to get Sparx5 upstreamed. The mem_ops (or dirmap) and polled mode are both performance enhancements, which can be pulled from my series if it creates too much noise. I can then add the necessary on top of your work/current kernel at a later time. > One thing I can tell about the mem_ops he implemented, is that they aren't > mem_ops, but dirmap (as you remember it's also implemented in my code, but with > alignment specific), and the exec_mem_op partly consists of a code, which belong > to the supports_op() callback. The rest of my comments will be inlined in the > patches. > > -Sergey -- Lars Povlsen, Microchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89174C433DF for ; Fri, 15 May 2020 09:12:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E2552065C for ; Fri, 15 May 2020 09:12:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="t02VwuUj"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="MZAqo+2V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E2552065C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-Reply-To:Subject:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=T9ImOiy4BjI+Jd1hpPvnFao1YJrz87eid32QqI4SXVc=; b=t02VwuUjVkcCZev842UIRvnHKN XPOtG16oKRaoNIc6Sb3mDEbwJURkqsbdmIu72PZ3yLGuGyTi4PK+Mfazzo7X4+22+Viy8G8eUsXBI gWpThk6tgv2ufuPzVleXefIvFEj1KF9QDoRr1JZNbI2PpmqlxFP9yDw/7taDuSwtJa9EffgYYDnJT 7oR9f/v2mYmHkJoFqLyGV3BlR4Sb9+GD1KHs1woCCrP/2Uv0HZxuB7+5OB9Sh+hBxARtBWKWO0nl4 Sg10kq0pkj05SnKLx7+iKjHjlHNWgeQqq16+EIl+akiGLBllMjARoc4WtqIBR0zhrFaPvDZeURhFC 0oVexcdw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZWO0-0003Xq-RY; Fri, 15 May 2020 09:12:08 +0000 Received: from esa1.microchip.iphmx.com ([68.232.147.91]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZWNv-0003BI-D8 for linux-arm-kernel@lists.infradead.org; Fri, 15 May 2020 09:12:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1589533923; x=1621069923; h=references:from:to:cc:subject:in-reply-to:date: message-id:mime-version; bh=wmtlMa/ByzxofhuCC0VPeSnxK6BCfzWRYql8RxVBaqc=; b=MZAqo+2VmnnrNNDiNjQxYQG9fAkBotUvE43X0CLsGikWh47PYPNzNgko nu/QwFMmxXXYRlkl8kPw5kOyPoKgbXBLdK1H45I/ayJzKs7PXuS3bUBNH jwkTknZz3I/kIzq5NZqJxjJMsA/ElBIohh1tgdPpvRsh3YFV6DD1xrxDi DNsIvSH4GKmZh4neB9ShipJKNDuT+zuVm1kqKFmiE+B/tNRMT7a4fMlr5 Q0hWB2adom212yrooCDPGQZfLHj5VrdxN2m2R5EQ3Tw3iZbs43K66Trul 9pjZ10ct2FV6o/Z1MS5WSNdWUvwndLGKwjYu8HGRDUB1/cG1wTnARB97i A==; IronPort-SDR: DiM+U75P+/Md9FzuxnzG9/z0ceXFZvbHHtzFIn11OpL0g9Q1x1Uby3/VZY5m1NeVYWhvUBPmE+ fgXUBBDmoZtQ367KyOjQZknEXfD5iM3FrLkBAERTap365oNNgrj1v8ezcplKZf610CTi+9QIoE o5MSEPl/7koBuzmySNOL7Y4LO3u9rXNzVcL3jJlTliM6j+9gKvuMN9IwP6het51vlvoYSL5FN4 fOUTEcECWvT0h+Gp2PovBvNtR1UGsmCCQYbZxYGTpCE4WgWkOBOKcEjLw/SxtEbpYrTSxwouNm V6c= X-IronPort-AV: E=Sophos;i="5.73,394,1583218800"; d="scan'208";a="79762318" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 15 May 2020 02:11:52 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 15 May 2020 02:11:52 -0700 Received: from soft-dev15.microsemi.net.microchip.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 15 May 2020 02:11:49 -0700 References: <20200513140031.25633-1-lars.povlsen@microchip.com> <20200513140031.25633-2-lars.povlsen@microchip.com> <20200513142050.GH4803@sirena.org.uk> <20200514130407.guyk3r4ltjvszy5s@mobilestation> From: Lars Povlsen To: Serge Semin Subject: Re: [PATCH 01/10] spi: dw: Add support for polled operation via no IRQ specified in DT In-Reply-To: <20200514130407.guyk3r4ltjvszy5s@mobilestation> Date: Fri, 15 May 2020 11:11:48 +0200 Message-ID: <874kshpnor.fsf@soft-dev15.microsemi.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200515_021203_494756_A4C74B63 X-CRM114-Status: GOOD ( 14.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Cc: devicetree@vger.kernel.org, Alexandre Belloni , Andy Shevchenko , linux-kernel@vger.kernel.org, Serge Semin , linux-spi@vger.kernel.org, SoC Team , Mark Brown , linux-arm-kernel@lists.infradead.org, Microchip Linux Driver Support , Lars Povlsen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Serge Semin writes: > Hi Mark > > On Wed, May 13, 2020 at 03:20:50PM +0100, Mark Brown wrote: >> On Wed, May 13, 2020 at 04:00:22PM +0200, Lars Povlsen wrote: >> > With this change a SPI controller can be added without having a IRQ >> > associated, and causing all transfers to be polled. For SPI controllers >> > without DMA, this can significantly improve performance by less >> > interrupt handling overhead. >> >> This overlaps substantially with some work that Serge Semin (CCed) has >> in progress, please coordinate with him. > > Thanks for copying me these mails. I haven't been Cc'ed in the series and > hasn't been subscribed to the SPI mailing list, so I would have definitely > missed that. > > I would like to coordinate my efforts with Lars. I'll have the patchset reviewed > soon in addition providing my comments/suggestions of how to make it useful for > both mine and Lars solution. Serge - thanks for taking on this. Note that my primary concern now is to get Sparx5 upstreamed. The mem_ops (or dirmap) and polled mode are both performance enhancements, which can be pulled from my series if it creates too much noise. I can then add the necessary on top of your work/current kernel at a later time. > One thing I can tell about the mem_ops he implemented, is that they aren't > mem_ops, but dirmap (as you remember it's also implemented in my code, but with > alignment specific), and the exec_mem_op partly consists of a code, which belong > to the supports_op() callback. The rest of my comments will be inlined in the > patches. > > -Sergey -- Lars Povlsen, Microchip _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel