From: Jani Nikula <jani.nikula@linux.intel.com>
To: Anshuman Gupta <anshuman.gupta@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/4] drm/i915: HDCP support on above PORT_E
Date: Tue, 28 Jan 2020 16:21:48 +0200 [thread overview]
Message-ID: <874kwfd5kz.fsf@intel.com> (raw)
In-Reply-To: <878slrd5mh.fsf@intel.com>
On Tue, 28 Jan 2020, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Tue, 28 Jan 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote:
>> As Gen12 onwards there are HDCP instances for each transcoder
>> instead of port, remove the (port >=PORT_E) hdcp support
>> limitation.
>>
>> CC: Ramalingam C <ramalingam.c@intel.com>
>> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_hdcp.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
>> index be083136eee2..d3a1dd791ff9 100644
>> --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
>> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
>> @@ -922,7 +922,8 @@ static void intel_hdcp_prop_work(struct work_struct *work)
>> bool is_hdcp_supported(struct drm_i915_private *dev_priv, enum port port)
>> {
>> /* PORT E doesn't have HDCP, and PORT F is disabled */
PS. It's probably best to nuke the comment.
>> - return INTEL_INFO(dev_priv)->display.has_hdcp && port < PORT_E;
>> + return INTEL_INFO(dev_priv)->display.has_hdcp &&
>> + ((INTEL_GEN(dev_priv) >= 12) || port < PORT_E);
>
> Superfluous braces around (INTEL_GEN(dev_priv) >= 12).
>
> BR,
> Jani.
>
>> }
>>
>> static int
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-28 14:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 13:54 [Intel-gfx] [PATCH 0/4] HDCP Misc series Anshuman Gupta
2020-01-28 13:54 ` [Intel-gfx] [PATCH 1/4] drm/i915/hdcp: Update CP as per the kernel internal state Anshuman Gupta
2020-01-28 14:19 ` Jani Nikula
2020-01-28 15:44 ` Anshuman Gupta
2020-01-28 16:15 ` Anshuman Gupta
2020-02-05 5:07 ` Anshuman Gupta
2020-03-03 14:36 ` Maarten Lankhorst
2020-03-03 16:35 ` Anshuman Gupta
2020-03-04 8:43 ` Maarten Lankhorst
2020-03-05 5:56 ` Anshuman Gupta
2020-01-28 13:54 ` [Intel-gfx] [PATCH 2/4] drm/i915: HDCP support on above PORT_E Anshuman Gupta
2020-01-28 14:20 ` Jani Nikula
2020-01-28 14:21 ` Jani Nikula [this message]
2020-01-29 13:26 ` [Intel-gfx] [PATCH v2 " Anshuman Gupta
2020-02-07 14:03 ` Ramalingam C
2020-01-28 13:54 ` [Intel-gfx] [PATCH 3/4] drm/i915: debugfs info print "HDCP shim isn't available" Anshuman Gupta
2020-02-07 14:13 ` Ramalingam C
2020-01-28 13:54 ` [Intel-gfx] [PATCH 4/4] drm/i915: Add HDCP2.2 capable debug print Anshuman Gupta
2020-01-28 14:23 ` Jani Nikula
2020-02-07 14:16 ` Ramalingam C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kwfd5kz.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=anshuman.gupta@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.