All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/python-autobahn: add missing dependency on C++
@ 2019-10-29 20:37 Arnout Vandecappelle
  2019-11-01  7:19 ` Peter Korsgaard
  2019-11-06 22:42 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2019-10-29 20:37 UTC (permalink / raw)
  To: buildroot

The indirect dependency via python-cryptography was not set in the
Config.in.

Detected with randconfig.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/python-autobahn/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/python-autobahn/Config.in b/package/python-autobahn/Config.in
index e08d5d58a1..ba54d8b12f 100644
--- a/package/python-autobahn/Config.in
+++ b/package/python-autobahn/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_PYTHON_AUTOBAHN
 	bool "python-autobahn"
+	depends on BR2_INSTALL_LIBSTDCPP # python-cryptography -> python-pyasn
 	select BR2_PACKAGE_PYTHON_CRYPTOGRAPHY # runtime
 	select BR2_PACKAGE_PYTHON_SIX # runtime
 	select BR2_PACKAGE_PYTHON_TXAIO # runtime
@@ -8,3 +9,6 @@ config BR2_PACKAGE_PYTHON_AUTOBAHN
 	  framework.
 
 	  https://pypi.python.org/pypi/autobahn
+
+comment "python-autobahn needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/python-autobahn: add missing dependency on C++
  2019-10-29 20:37 [Buildroot] [PATCH] package/python-autobahn: add missing dependency on C++ Arnout Vandecappelle
@ 2019-11-01  7:19 ` Peter Korsgaard
  2019-11-06 22:42 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2019-11-01  7:19 UTC (permalink / raw)
  To: buildroot

>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 > The indirect dependency via python-cryptography was not set in the
 > Config.in.

 > Detected with randconfig.

 > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

You forgot to propagate this to the reverse dependencies (daphne,
channels, channels-redis).

Committed with that fixes, thanks.

 > ---
 >  package/python-autobahn/Config.in | 4 ++++
 >  1 file changed, 4 insertions(+)

 > diff --git a/package/python-autobahn/Config.in b/package/python-autobahn/Config.in
 > index e08d5d58a1..ba54d8b12f 100644
 > --- a/package/python-autobahn/Config.in
 > +++ b/package/python-autobahn/Config.in
 > @@ -1,5 +1,6 @@
 >  config BR2_PACKAGE_PYTHON_AUTOBAHN
 >  	bool "python-autobahn"
 > +	depends on BR2_INSTALL_LIBSTDCPP # python-cryptography -> python-pyasn
 >  	select BR2_PACKAGE_PYTHON_CRYPTOGRAPHY # runtime
 >  	select BR2_PACKAGE_PYTHON_SIX # runtime
 >  	select BR2_PACKAGE_PYTHON_TXAIO # runtime
 > @@ -8,3 +9,6 @@ config BR2_PACKAGE_PYTHON_AUTOBAHN
 >  	  framework.
 
 >  	  https://pypi.python.org/pypi/autobahn
 > +
 > +comment "python-autobahn needs a toolchain w/ C++"
 > +	depends on !BR2_INSTALL_LIBSTDCPP
 > -- 
 > 2.21.0

 > _______________________________________________
 > buildroot mailing list
 > buildroot at busybox.net
 > http://lists.busybox.net/mailman/listinfo/buildroot

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/python-autobahn: add missing dependency on C++
  2019-10-29 20:37 [Buildroot] [PATCH] package/python-autobahn: add missing dependency on C++ Arnout Vandecappelle
  2019-11-01  7:19 ` Peter Korsgaard
@ 2019-11-06 22:42 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2019-11-06 22:42 UTC (permalink / raw)
  To: buildroot

>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 > The indirect dependency via python-cryptography was not set in the
 > Config.in.

 > Detected with randconfig.

 > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Committed to 2019.08.x (2019.02.x has an older autobahn not using cryptography), thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-11-06 22:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-29 20:37 [Buildroot] [PATCH] package/python-autobahn: add missing dependency on C++ Arnout Vandecappelle
2019-11-01  7:19 ` Peter Korsgaard
2019-11-06 22:42 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.