From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88DDFC47404 for ; Fri, 11 Oct 2019 10:34:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61AD02084C for ; Fri, 11 Oct 2019 10:34:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61AD02084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48274 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIsFT-0002Qg-IH for qemu-devel@archiver.kernel.org; Fri, 11 Oct 2019 06:34:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36676) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIsDL-00010s-3Y for qemu-devel@nongnu.org; Fri, 11 Oct 2019 06:32:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIsDI-0006lH-Un for qemu-devel@nongnu.org; Fri, 11 Oct 2019 06:32:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37406) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIsDI-0006l2-P6 for qemu-devel@nongnu.org; Fri, 11 Oct 2019 06:32:00 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5B9024FCC7; Fri, 11 Oct 2019 10:31:59 +0000 (UTC) Received: from redhat.com (ovpn-117-120.ams2.redhat.com [10.36.117.120]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E48E260BE1; Fri, 11 Oct 2019 10:31:58 +0000 (UTC) From: Juan Quintela To: Wei Yang Subject: Re: [PATCH 2/4] migration/multifd: use pages->allocated instead of the static max In-Reply-To: <20191011085050.17622-3-richardw.yang@linux.intel.com> (Wei Yang's message of "Fri, 11 Oct 2019 16:50:48 +0800") References: <20191011085050.17622-1-richardw.yang@linux.intel.com> <20191011085050.17622-3-richardw.yang@linux.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Date: Fri, 11 Oct 2019 12:31:56 +0200 Message-ID: <874l0fwp2b.fsf@trasno.org> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 11 Oct 2019 10:31:59 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: dgilbert@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Wei Yang wrote: > multifd_send_fill_packet() prepares meta data for following pages to > transfer. It would be more proper to fill pages->allocated instead of > static max value, especially we want to support flexible packet size. > > Signed-off-by: Wei Yang Reviewed-by: Juan Quintela It don't really matters. We send full packets except the last one or somesuch extern reason. Only makes a difference if for that channel only is sent a partial packet.